New issue
Advanced search Search tips

Issue 854703 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Add USB device filter validation and matching tests

Project Member Reported by reillyg@chromium.org, Jun 20 2018

Issue description

The WebUSB specification includes an algorithm for validating that a filter is well formed. Implement these checks and add web tests for them.

https://wicg.github.io/webusb/#is-not-a-valid-filter
 
Owner: odejesush@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/722c9273de82f119a0c5648e5a37457232bee1a8

commit 722c9273de82f119a0c5648e5a37457232bee1a8
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Fri Aug 31 20:14:02 2018

Add validation to the requestDevice filters

This change adds validation checks to the USBDeviceFilter parameters
passed into navigator.usb.requestDevice.

Bug:  854703 
Change-Id: I921a7f30a9e2ec5d46d3a74801de594565ab8a6f
Reviewed-on: https://chromium-review.googlesource.com/1196034
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588140}
[modify] https://crrev.com/722c9273de82f119a0c5648e5a37457232bee1a8/third_party/WebKit/LayoutTests/external/wpt/webusb/usb.https.window.js
[modify] https://crrev.com/722c9273de82f119a0c5648e5a37457232bee1a8/third_party/blink/renderer/modules/webusb/usb.cc

Status: Fixed (was: Assigned)

Sign in to add a comment