Issue 854700 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	est...@chromium.org
Closed:	Jun 2018
Cc:	mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug

Blocking:
issue 837684

Implement UserActivityMonitor with ws2

Project Member Reported by sky@chromium.org, Jun 20 2018

Issue description

The implementation for ws is here: https://chromium.googlesource.com/chromium/src/+/master/services/ui/ws/user_activity_monitor.cc . ui::Service exports the interface here: https://chromium.googlesource.com/chromium/src/+/master/services/ui/service.cc#472 . For ws2 can use a PretargetHandler on Env to observe events and send out the right calls.

I'm hoping that services/ui/ws can go away entirely soonish. So, feel free to copy the existing one into ws2 and and it an EventTarget directly.

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f57e208f9d59423f314f81e82aa8aacb577f8f3c

commit f57e208f9d59423f314f81e82aa8aacb577f8f3c
Author: Evan Stade <estade@chromium.org>
Date: Fri Jun 22 18:27:48 2018

Create UserActivityMonitor for ws2.

Mostly copied from ws::UserActivityMonitor.
Nothing actually connects to it yet.

Bug:  854700 
Change-Id: I478942c4f5462e9632454bf7385aa827f015e05d
Reviewed-on: https://chromium-review.googlesource.com/1108974
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569704}
[modify] https://crrev.com/f57e208f9d59423f314f81e82aa8aacb577f8f3c/services/ui/common/task_runner_test_base.h
[modify] https://crrev.com/f57e208f9d59423f314f81e82aa8aacb577f8f3c/services/ui/ws2/BUILD.gn
[add] https://crrev.com/f57e208f9d59423f314f81e82aa8aacb577f8f3c/services/ui/ws2/user_activity_monitor.cc
[add] https://crrev.com/f57e208f9d59423f314f81e82aa8aacb577f8f3c/services/ui/ws2/user_activity_monitor.h
[add] https://crrev.com/f57e208f9d59423f314f81e82aa8aacb577f8f3c/services/ui/ws2/user_activity_monitor_unittest.cc
[modify] https://crrev.com/f57e208f9d59423f314f81e82aa8aacb577f8f3c/services/ui/ws2/window_service.cc
[modify] https://crrev.com/f57e208f9d59423f314f81e82aa8aacb577f8f3c/services/ui/ws2/window_service.h

Comment 2 by est...@chromium.org, Jun 28 2018

Status: Fixed (was: Assigned)

►

Issue 854700 link

Issue metadata

Implement UserActivityMonitor with ws2

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 22 2018

Comment 1 Deleted

Comment 2 by est...@chromium.org, Jun 28 2018

Comment 2 Deleted

Sign in to add a comment