New issue
Advanced search Search tips

Issue 854647 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 773928
Owner:
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

PrintPreview tests are failing on Win 7

Project Member Reported by jonr...@chromium.org, Jun 20 2018

Issue description

OS: Win 7
Test Suite: browser_tests
Tests: PrintPreview*
Bot: Win7 Tests (dbg)(1)
First failing build:  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69834

Suspect CLs:
  - https://chromium-review.googlesource.com/c/chromium/src/+/1104985
  - https://chromium-review.googlesource.com/c/chromium/src/+/1103307

Example failure: 

web_ui_browser_test.cc(481)] CONDITION FAILURE: encountered javascript console error(s):
[6192:4136:0619/104758.877:ERROR:web_ui_browser_test.cc(483)] JS ERROR: '[6192:4136:0619/104756.800:ERROR:CONSOLE(290)] "Uncaught (in promise) TypeError: Cannot set property 'textContent' of null", source: chrome://print/new/app.js (290)
'
[6192:4136:0619/104758.877:ERROR:web_ui_browser_test.cc(485)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest-gen.cc(1540): error: Value of: RunJavascriptTestF( true, "PrintPreviewPreviewGenerationTest", "PageRange")
  Actual: false
Expected: true
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x03482D6A+90]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x03499B2A+74]
	testing::internal::AssertHelper::operator= [0x0349963B+75]
	PrintPreviewPreviewGenerationTest_PageRange_Test::RunTestOnMainThread [0x0337E078+2344]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x05AD8794+804]
	??$Invoke@P8BrowserTestBase@content@@AEXXZPAV12@$$V@?$FunctorTraits@P8BrowserTestBase@content@@AEXXZX@internal@base@@SAXP8BrowserTestBase@content@@AEXXZ$$QAPAV34@@Z [0x05ADA6BC+28]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BrowserTestBase::*const &)(void),content::BrowserTestBase *> [0x05ADA5FF+79]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::RunImpl<void (__thiscall content::BrowserTestBase::*const &)(void),std [0x05ADA595+85]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::Run [0x05ADA48F+63]
	base::RepeatingCallback<void __cdecl(void)>::Run [0x013EE022+50]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x07BB639F+7071]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x07BB477E+398]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x5FC01016+342]
	??$Invoke@P8BrowserMainLoop@content@@AEHXZPAV12@$$V@?$FunctorTraits@P8BrowserMainLoop@content@@AEHXZX@internal@base@@SAHP8BrowserMainLoop@content@@AEHXZ$$QAPAV34@@Z [0x5FC0B48C+28]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x5FC0B3BF+79]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x5FC0B355+85]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x5FC0B20F+63]
	base::RepeatingCallback<int __cdecl(void)>::Run [0x6055B1D2+50]
	content::StartupTaskRunner::RunAllTasksNow [0x60E90E89+137]
	content::BrowserMainLoop::CreateStartupTasks [0x5FBFED25+1493]
	content::BrowserMainRunnerImpl::Initialize [0x5FC1140F+1983]
	content::BrowserMain [0x5FBF8519+265]
	content::RunBrowserProcessMain [0x624F7D49+393]
	content::ContentMainRunnerImpl::Run [0x624F90D4+804]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x624F55C1+33]
	service_manager::Main [0x5C80372A+1418]
	content::ContentMain [0x624F7B3C+92]
	content::BrowserTestBase::SetUp [0x05AD8151+2913]
	InProcessBrowserTest::SetUp [0x059912F6+2086]

Hey Rebekah,
I'm assigning this to you as the author of two print cls in the failure range. The failure seems to be triggered by the JS change to chrome/browser/resources/print_preview/new/app.js

Could you PTAL or triage to a more appropriate owner? Thanks!
 
Mergedinto: 773928
Status: Duplicate (was: Assigned)
The problematic CL was reverted (see https://crbug.com/773928#c108) and re-landed with a fix here: https://crrev.com/c/1108539. Merging into the main bug.

Sign in to add a comment