New issue
Advanced search Search tips

Issue 854642 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Jun 2018
Cc:
amaralp@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Bottom toolbar's composited shadow should be visible when the corresponding android view is not.

Project Member Reported by mdjones@chromium.org, Jun 20 2018 
Currently the shadow's visibility is determined by the scroll offset (which usually aligns with the scroll offset being non-zero). We should update this to explicitly be tied to the android view's visibility.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68cdb61ca767ba2c457f13672619c52d511f1af1

commit 68cdb61ca767ba2c457f13672619c52d511f1af1
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Jun 21 16:55:03 2018

Update shadow visibility logic in ScrollingBottomViewSceneLayer

This patch updates the composited bottom toolbar's shadow visibility
to depend on the android view's visibility. If the android view is
visible, the compositor shadow is not.

Bug:  854642 
Change-Id: Ib1f3f1491fc8728ad5f49d8170145bd5d3161ce2
Reviewed-on: https://chromium-review.googlesource.com/1108343
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569305}
[modify] https://crrev.com/68cdb61ca767ba2c457f13672619c52d511f1af1/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ScrollingBottomViewSceneLayer.java

Comment 2 by mdjones@chromium.org, Jun 21 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment