Should we remove the current profile from the list of profiles? |
|||||||||
Issue descriptionPer discussion on https://groups.google.com/a/google.com/forum/#!topic/chrome-signin/My3tF_elvTs, there's a question of whether we should remove the current profile from the list of profiles in the user menu. cc'ing some folks that might be thinking about this. Assigning to Sabine as future-looking identity-related work.
,
Jun 20 2018
Patrick, if your eng team is going to be making the UI changes for that list of profiles as part of autofill home anyways, maybe you could just remove the entry for the current profile as well as part of those changes. If Sabine is on board, feel free to re-assign to the engineer working on that.
,
Jun 20 2018
Does this need to be private?
,
Jun 20 2018
,
Jun 22 2018
I agree that it's redundant. Happy to drop it. Patrick, as discussed in person today, it would be great if your engineers could just cover this as part of the other changes too. Let me know if not. Thanks!
,
Jul 4
,
Jul 23
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c68d5ce2f4391208e50e2e50bb1d6c3cecaa0c1 commit 4c68d5ce2f4391208e50e2e50bb1d6c3cecaa0c1 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Jul 23 19:43:56 2018 Remove the current profile from the profile chooser menu. Bug: 854638 Change-Id: I32e08f3f33558f7286f5cd80b05e86aa0dae0dd4 Reviewed-on: https://chromium-review.googlesource.com/1146817 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#577222} [modify] https://crrev.com/4c68d5ce2f4391208e50e2e50bb1d6c3cecaa0c1/chrome/browser/ui/views/profiles/profile_chooser_view.cc
,
Jul 25
I'd like to merge r577222 to M69. It's a tiny fix but saves some visual space for the profile chooser menu.
,
Jul 26
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d7a330b1fc3213def20ebda92606d8fc2c4c602 commit 9d7a330b1fc3213def20ebda92606d8fc2c4c602 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Jul 26 10:40:30 2018 Remove the current profile from the profile chooser menu. TBR=vasilii@chromium.org (cherry picked from commit 4c68d5ce2f4391208e50e2e50bb1d6c3cecaa0c1) Bug: 854638 Change-Id: I32e08f3f33558f7286f5cd80b05e86aa0dae0dd4 Reviewed-on: https://chromium-review.googlesource.com/1146817 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577222} Reviewed-on: https://chromium-review.googlesource.com/1151189 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#105} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/9d7a330b1fc3213def20ebda92606d8fc2c4c602/chrome/browser/ui/views/profiles/profile_chooser_view.cc
,
Jul 26
,
Aug 1
Tested this issue on Windows 10 on the build without fix 68.0.3397.0 and unable to reproduce the issue by following the below steps. 1. Launched Chrome and added few profiles. 2. On clicking on the Profiles button, can observe that Profile 1 is not seen in the list of Profiles. Attached is the screen shot for reference. vasilii@ Request you to check and confirm if anything is missed from our end in verifying the issue? Thanks..
,
Aug 1
Yeah, it always worked for non-Dice users. You need to switch #account-consistency flag to Dice. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nepper@chromium.org
, Jun 20 2018