New issue
Advanced search Search tips

Issue 854630 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 834185
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 736308



Sign in to add a comment

many virtual/outofblink-cors/http/tests/**/thorough tests flakily TIMEOUT with OOPIF

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 20 2018

Issue description

"virtual/outofblink-cors/http/tests/fetch/serviceworker/thorough/cors-base-https-other-https.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyawsSBUZsYWtlImB2aXJ0dWFsL291dG9mYmxpbmstY29ycy9odHRwL3Rlc3RzL2ZldGNoL3NlcnZpY2V3b3JrZXIvdGhvcm91Z2gvY29ycy1iYXNlLWh0dHBzLW90aGVyLWh0dHBzLmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Blocking: 736308
Components: Internals>Services>Network Internals>Sandbox>SiteIsolation
Labels: -Pri-1 Pri-3
Status: Available (was: Untriaged)
Summary: many virtual/outofblink-cors/http/tests/fetch/serviceworker/thorough tests flakily TIMEOUT with OOPIF (was: "virtual/outofblink-cors/http/tests/fetch/serviceworker/thorough/cors-base-https-other-https.html" is flaky)
For the current list:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests%20(with%20patch)&tests=virtual%2Foutofblink-cors%2Fhttp%2Ftests%2Ffetch%2Fserviceworker%2Fthorough


Screenshot from 2018-06-20 11-28-43.png
285 KB View Download
 Issue 854745  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b53d452b006c5eb1eaa0c4ec45694c498a30b9f5

commit b53d452b006c5eb1eaa0c4ec45694c498a30b9f5
Author: David Grogan <dgrogan@chromium.org>
Date: Wed Jun 20 20:29:50 2018

Mark many outofblink-cors tests as Timeout Pass

Found via looking for black or grey runs on
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests%20(with%20patch)&tests=virtual%2Foutofblink-cors%2Fhttp%2Ftests%2Ffetch%2Fserviceworker%2Fthorough

Bug:  854630 
Change-Id: I04e77bfbbf06d42063836ccfc7c03cdf3baf39bc
Reviewed-on: https://chromium-review.googlesource.com/1108455
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568988}
[modify] https://crrev.com/b53d452b006c5eb1eaa0c4ec45694c498a30b9f5/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
 Issue 854879  has been merged into this issue.
 Issue 855154  has been merged into this issue.
 Issue 855077  has been merged into this issue.
Summary: many virtual/outofblink-cors/http/tests/**/thorough tests flakily TIMEOUT with OOPIF (was: many virtual/outofblink-cors/http/tests/fetch/serviceworker/thorough tests flakily TIMEOUT with OOPIF)
Labels: OOR-CORS
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4594f8e6b003937a7f7cb2485654496f227a173

commit c4594f8e6b003937a7f7cb2485654496f227a173
Author: David Grogan <dgrogan@chromium.org>
Date: Thu Jun 21 21:41:59 2018

Sheriff: Mark more virtual/outofblink-cors/http/tests/**/thorough as TIMEOUT

TBR=anthonyvd@chromium.org

Bug:  854630 
Change-Id: I5685ee29e9b2b11b83483452683b07e09ca6245a
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1110550
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569380}
[modify] https://crrev.com/c4594f8e6b003937a7f7cb2485654496f227a173/third_party/WebKit/LayoutTests/TestExpectations

Owner: falken@chromium.org
Status: Assigned (was: Available)
falken@, can you triage this?
Looks just the same as  issue 834185  except somehow now  virtual/outofblink-cors/ is also failing along with the non-virtual tests.

There are already expectations for the non-vritual tests in FlagExpectations/site-per-process.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72ef4e47846d30d3fa26599c7864efd38def1704

commit 72ef4e47846d30d3fa26599c7864efd38def1704
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Jun 22 01:42:43 2018

Gardening: Move OOPIF only OOR-CORS failures to FlagExpectations/site-per-process

These are only flaky on OOPIF (site-per-process), and there are existing
flaky expectations for the non-OOR-CORS tests.

I'm not sure why the OOR-CORS tests regressed recently, but since it's
an experimental feature and the non-OOR-CORS tests are also flaky I'll
leave it for OOR-CORS or OOPIF team to look.

Bug:  854630 ,  834185 
Change-Id: I93db44e01e96adb0d0f715061b66f0f7ec3f2862
TBR: dgrogan
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1111479
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569500}
[modify] https://crrev.com/72ef4e47846d30d3fa26599c7864efd38def1704/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/72ef4e47846d30d3fa26599c7864efd38def1704/third_party/WebKit/LayoutTests/TestExpectations

Cc: yhirano@chromium.org
Owner: toyoshim@chromium.org
Assigning to toyoshim who is driving OOB/OOR-CORS.

Comment 16 by dougt@chromium.org, Jun 26 2018

Components: -Internals>Services>Network
Cc: blink-network-dev@chromium.org
 Issue 857602  has been merged into this issue.
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf222e82a321a0821354f03d5e8bcc069e41a1d6

commit cf222e82a321a0821354f03d5e8bcc069e41a1d6
Author: Adam Rice <ricea@chromium.org>
Date: Mon Jul 02 14:28:20 2018

OOPIF oob-cors redirect-loop-base-https-other-https.html is flaky

Add [ Failure Timeout ] expectations for
virtual/outofblink-cors/http/tests/fetch/workers/thorough/redirect-loop-base-https-other-https.html
with site_per_process and all variants.

Bug:  854630 
Change-Id: I204009be0538ebe8c0651cfbcd90e098ffb32dc3
Reviewed-on: https://chromium-review.googlesource.com/1122144
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571889}
[modify] https://crrev.com/cf222e82a321a0821354f03d5e8bcc069e41a1d6/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

 Issue 860202  has been merged into this issue.
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7078711ffa7d0890ddbcb7d34ae4fcca1e3786bb

commit 7078711ffa7d0890ddbcb7d34ae4fcca1e3786bb
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Jul 06 20:52:13 2018

Mark redirect-base-https-other-https.html as timing out

This test is flaky with site-per-process:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests&tests=redirect-base-https-other-https.html

The test lines have also been sorted to make adding these easier.

TBR=ynovikov@chromium.org

No-Try: true
Bug:  834185 ,  854630 
Change-Id: I370a9fd75326ebecc90253b0fc208bc2c915b83f
Reviewed-on: https://chromium-review.googlesource.com/1128258
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573065}
[modify] https://crrev.com/7078711ffa7d0890ddbcb7d34ae4fcca1e3786bb/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3

commit 627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jul 20 01:26:52 2018

[OOR-CORS] Reorganize layout test expectations for site-per-process

virtual/outofblink-cors and virtual/outofblink-cors-ns should inherit
existing test expectations. There is a dedicated bug for
virtual/outofblink-cors,  https://crbug.com/854630 , but that doesn't
make sense as none of them are OOR-CORS specific, so I changed the bug
number.

TBR=dcheng@chromium.org

No-Try: true
Bug:  834185 ,  854630 , 859988, 862184
Change-Id: I4886c8ed063e95306d79234649dbc54a8bb53100
Reviewed-on: https://chromium-review.googlesource.com/1144582
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576749}
[modify] https://crrev.com/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3/third_party/WebKit/LayoutTests/TestExpectations

Mergedinto: 834185
Status: Duplicate (was: Assigned)

Sign in to add a comment