New issue
Advanced search Search tips

Issue 854628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 448486



Sign in to add a comment

Remove MergeSessionLoadPage interstitial

Project Member Reported by carlosil@chromium.org, Jun 20 2018

Issue description

As part of go/committed-interstitials, the MergeSessionLoadPage interstitial should be removed, and the wait for MergeSession handled from the existing navigation throttle. 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a3b5f03feabf4db999ba581b54e59583eee29b1

commit 7a3b5f03feabf4db999ba581b54e59583eee29b1
Author: Carlos IL <carlosil@chromium.org>
Date: Fri Jun 22 17:34:08 2018

Removed MergeSessionLoadPage.

As part of committed interstitials, the MergeSessionLoadPage interstitial was
removed, the wait for MergeSession now happens directly in the
MergeSessionNavigationThrottle.

Bug:  854628 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib5c73824d08de8733b9b47e113587a552aa9a828
Reviewed-on: https://chromium-review.googlesource.com/1108186
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569682}
[modify] https://crrev.com/7a3b5f03feabf4db999ba581b54e59583eee29b1/chrome/browser/browser_resources.grd
[modify] https://crrev.com/7a3b5f03feabf4db999ba581b54e59583eee29b1/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/f3c2edb0419a7f53628f98d3f82e9fdfdbd73087/chrome/browser/chromeos/login/signin/merge_session_load_page.cc
[delete] https://crrev.com/f3c2edb0419a7f53628f98d3f82e9fdfdbd73087/chrome/browser/chromeos/login/signin/merge_session_load_page.h
[delete] https://crrev.com/f3c2edb0419a7f53628f98d3f82e9fdfdbd73087/chrome/browser/chromeos/login/signin/merge_session_load_page_unittest.cc
[modify] https://crrev.com/7a3b5f03feabf4db999ba581b54e59583eee29b1/chrome/browser/chromeos/login/signin/merge_session_navigation_throttle.cc
[modify] https://crrev.com/7a3b5f03feabf4db999ba581b54e59583eee29b1/chrome/browser/chromeos/login/signin/merge_session_navigation_throttle.h
[add] https://crrev.com/7a3b5f03feabf4db999ba581b54e59583eee29b1/chrome/browser/chromeos/login/signin/merge_session_navigation_throttle_unittest.cc
[modify] https://crrev.com/7a3b5f03feabf4db999ba581b54e59583eee29b1/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc
[modify] https://crrev.com/7a3b5f03feabf4db999ba581b54e59583eee29b1/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h
[modify] https://crrev.com/7a3b5f03feabf4db999ba581b54e59583eee29b1/chrome/browser/chromeos/login/signin/oauth2_login_manager.h
[delete] https://crrev.com/f3c2edb0419a7f53628f98d3f82e9fdfdbd73087/chrome/browser/resources/chromeos/merge_session_load.html

Status: Fixed (was: Started)

Sign in to add a comment