VR: Allow Chrome to launch into 2D mode on standalones. |
||||||
Issue descriptionb/110151257 Unfortunately late in the launch cycle, we've been made aware of platform requirements we weren't previously aware of, and need to make Chrome on standalones support both VR and 2D launches. This means we need to trust the intent sender to know whether Chrome should be launching into 2D, even when the user is in a VR session or using a standalone VR device.
,
Jun 22 2018
Requesting merge to 68. Yes, this is somewhat of a large change for this late in the M68 cycle, but this addresses critical feedback from our launch review with the Daydream platform, where us launching VR Chrome was breaking some critical platform functionality. Our QA team, and also a bunch of our SWEs have been banging on this change for the last 2 days (with an M68 build I cherry-picked this into), so we're pretty confident it doesn't break anything. Also, any breakages should be restricted to VR, as this change only affects VR intent handling/startup.
,
Jun 22 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 22 2018
Why is there no tests in your CL
,
Jun 22 2018
We have no bots that run on standalone VR headsets. I'll add a test for phones, though they'll never care about the behaviour change here.
,
Jun 22 2018
I've got a test added here: https://chromium-review.googlesource.com/c/chromium/src/+/1112583
,
Jun 22 2018
Merge approved upon landing the test on trunk.
,
Jun 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d388b73618b22d082f3ea66f6f73c9ded1d4b33 commit 6d388b73618b22d082f3ea66f6f73c9ded1d4b33 Author: Michael Thiessen <mthiesse@chromium.org> Date: Sat Jun 23 22:43:00 2018 VR: Add test for 2D Chrome intents exiting VR. Bug: 854626 Change-Id: I97da35144ee3a8de2c4d6e04d8456dc56b0fc076 Reviewed-on: https://chromium-review.googlesource.com/1112583 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#569903} [modify] https://crrev.com/6d388b73618b22d082f3ea66f6f73c9ded1d4b33/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/6d388b73618b22d082f3ea66f6f73c9ded1d4b33/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestVrShellDelegate.java [modify] https://crrev.com/6d388b73618b22d082f3ea66f6f73c9ded1d4b33/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java [modify] https://crrev.com/6d388b73618b22d082f3ea66f6f73c9ded1d4b33/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java [modify] https://crrev.com/6d388b73618b22d082f3ea66f6f73c9ded1d4b33/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java [modify] https://crrev.com/6d388b73618b22d082f3ea66f6f73c9ded1d4b33/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8004950ffc609ec3d7e00d039731118b877e9186 commit 8004950ffc609ec3d7e00d039731118b877e9186 Author: Michael Thiessen <mthiesse@chromium.org> Date: Mon Jun 25 13:54:13 2018 VR: Allow Chrome to launch into 2D mode on Standalone VR devices. Standalones need 2D Chrome support for things like privacy policy links from Settings, etc., where entering VR would wreck the task stack and take the user out of the proper context, etc. Basically, when Chrome is asked to launch into 2D, we need to respect that and launch into 2D even if we're on a VR device, or in a VR session. TBR=mthiesse@chromium.org (cherry picked from commit e7d9b7c0b7814557a8c517f87888970dcceddc17) Bug: 854626 Change-Id: I90765e2b402a72a1adf6f23e80c39dc6f8ec0046 Reviewed-on: https://chromium-review.googlesource.com/1108138 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568942} Reviewed-on: https://chromium-review.googlesource.com/1113519 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#508} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/8004950ffc609ec3d7e00d039731118b877e9186/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/8004950ffc609ec3d7e00d039731118b877e9186/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/8004950ffc609ec3d7e00d039731118b877e9186/chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java [modify] https://crrev.com/8004950ffc609ec3d7e00d039731118b877e9186/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java [modify] https://crrev.com/8004950ffc609ec3d7e00d039731118b877e9186/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrIntentUtils.java [modify] https://crrev.com/8004950ffc609ec3d7e00d039731118b877e9186/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Jun 25 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jun 20 2018