New issue
Advanced search Search tips

Issue 854622 link

Starred by 1 user
Status: Verified
Owner:
stkhapugin@chromium.org
Closed: Jul 12
Cc:
pinkerton@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Hide clear button when the omnibox is empty

Project Member Reported by stkhapugin@chromium.org, Jun 20 2018 
When there's no text in the omnibox, the clear button should be hidden.

Also the clear button code deserves an explanation comment as to why we can't use the system one.

Comment 1 by pinkerton@chromium.org, Jun 22 2018

Cc: pinkerton@chromium.org
I can't reproduce this. How can I get into this state with empty text and the clear button?

Comment 2 by stkhapugin@chromium.org, Jun 22 2018 

pinkerton: on latest canary, clear the textfield. Observe the clear button is still visible.

Comment 3 by stkhapugin@chromium.org, Jun 29 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0056ea7bc75754d4ac5388b0ee9108cc604945d

commit a0056ea7bc75754d4ac5388b0ee9108cc604945d
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Thu Jul 12 13:35:49 2018

[iOS] Hide clear button when the textfield is empty.

Makes UI Refresh omnibox hide the clear button when the textfield
is empty.

Bug:  854622 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7905efa0c5ead8c7c2884c27474ec992b970355c
Reviewed-on: https://chromium-review.googlesource.com/1122627
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574549}
[modify] https://crrev.com/a0056ea7bc75754d4ac5388b0ee9108cc604945d/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm

Comment 5 by stkhapugin@chromium.org, Jul 12

Status: Fixed (was: Started)

Comment 6 by vbarig...@chromium.org, Jul 17

Status: Verified (was: Fixed)
Verified on chrome canary version 69.0.3494.0 on iPhone 8 plus, iPhone 6s plus with iOS 11.4.1, 12 beta 3; iPad pro with iOS 11.4.1.  Clear button "x" is not displayed on clearing text in omnibox.
►

Sign in to add a comment