New issue
Advanced search Search tips

Issue 854621 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove the SSLClientSocket / SSLClientSocketImpl split

Project Member Reported by rsleevi@chromium.org, Jun 20 2018

Issue description

Currently we have net/socket/ssl_client_socket.h and net/socket/ssl_client_socket_impl.h.

SSLClientSocket has three public static methods:
- SetSSLKeyLogFile
- IgnoreCertError
- ClearSessionCache

SSLClientSocket has one protected static method:
- SerializeNextProtos

It also has two private members:
- signed_cert_timestamps_received_
- stapled_ocsp_response_received_

The protected/private members are only used by test (and the latter two can be tested using CTVerifier/CertVerifier interfaces, thus don't need to exist as they do), while the former three public methods all just delegate to the Impl

We should clean this up and unify these classes so we don't have an unnecessary and arbitrary split.

Further, two of the public static methods - ClearSessionCache and SetSSLKeyLogFile - are logically part of the SSLClientSocketContext, as noted in the header.
 

Sign in to add a comment