components_unittests and content_unittests outputs end with a similar failure:



I  896.464s run_tests_on_device(01e2f6a326e04093)  [==========] Running 53 tests from 11 test cases.
I  896.464s run_tests_on_device(01e2f6a326e04093)  [----------] Global test environment set-up.
I  896.464s run_tests_on_device(01e2f6a326e04093)  [----------] 1 test from WebContentsMainFrameObserverTest
I  896.464s run_tests_on_device(01e2f6a326e04093)  [ RUN      ] WebContentsMainFrameObserverTest.IgnoresSameDocumentNavigation
I  896.464s run_tests_on_device(01e2f6a326e04093)  ../../content/browser/web_contents/web_contents_view_android.cc:166:10: runtime error: control flow integrity check for type 'content::RenderWidgetHostViewAndroid' failed during base-to-derived cast (vtable address 0xdfad98d8)
I  896.464s run_tests_on_device(01e2f6a326e04093)  0xdfad98d8: note: vtable is of type 'content::TestRenderWidgetHostView'
I  896.464s run_tests_on_device(01e2f6a326e04093)   90 6c e2 df  5d 1b 92 dd c3 1b 92 dd  9d 25 92 dd a1 75 91 db  9f 25 92 dd 35 85 91 db  cd 85 91 db
I  896.464s run_tests_on_device(01e2f6a326e04093)                ^ 
I  896.464s run_tests_on_device(01e2f6a326e04093)  #0 pc 0x4ff8ff6 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.464s run_tests_on_device(01e2f6a326e04093)  #1 pc 0x4ffa002 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #2 pc 0x4ff9d70 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #3 pc 0x4f84e96 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #4 pc 0x4f6ce22 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #5 pc 0x6e77ec2 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #6 pc 0x6e69762 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #7 pc 0x6e69b28 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #8 pc 0x38d28f8 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #9 pc 0x3a650ce /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #10 pc 0x3a65722 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #11 pc 0x3a65ce4 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #12 pc 0x3a6a5a2 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #13 pc 0x3a6a326 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #14 pc 0x60d2cb6 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #15 pc 0x4709dd4 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #16 pc 0x60d534e /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #17 pc 0x36e601a /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #18 pc 0x56ac9ee /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  #19 pc 0x56ac7d2 /data/app/org.chromium.native_test-1/lib/arm/lib_components_unittests__library.so
I  896.465s run_tests_on_device(01e2f6a326e04093)  
I  896.465s run_tests_on_device(01e2f6a326e04093)  [ CRASHED      ]
I  896.465s run_tests_on_device(01e2f6a326e04093)  [host]> /b/swarming/w/ir/build/android/pylib/symbols/../../../../third_party/android_platform/development/scripts/stack --arch arm64 --output-directory /b/swarming/w/ir/out/Release --more-info /b/swarming/w/itneBF1H/tmpEuoXYz
I  897.911s TimeoutThread-1-for-run_tests_on_device(01e2f6a326e04093)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 01e2f6a326e04093 shell '( test -e /data/tombstones );echo %$?'
I  897.943s TimeoutThread-1-for-run_tests_on_device(01e2f6a326e04093)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 01e2f6a326e04093 shell '( TZ=utc ls -a -l /data/tombstones/ );echo %$?'
I  898.007s TimeoutThread-1-for-run_tests_on_device(01e2f6a326e04093)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 01e2f6a326e04093 shell '( TZ=UTC date );echo %$?'
I  898.071s TimeoutThread-1-for-run_tests_on_device(01e2f6a326e04093)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 01e2f6a326e04093 shell '( TZ=utc ls -a -l /data/tombstones/ );echo %$?'
I  898.094s TimeoutThread-1-for-run_tests_on_device(01e2f6a326e04093)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 01e2f6a326e04093 pull /data/tombstones/tombstone_00 /b/swarming/w/itneBF1H/tmpEgbD4T/tmp_ReadFileWithPull
I  898.172s TimeoutThread-1-for-run_tests_on_device(01e2f6a326e04093)  [host]> /b/swarming/w/ir/third_party/android_tools/sdk/platform-tools/adb -s 01e2f6a326e04093 shell '( rm /data/tombstones/tombstone_00 );echo %$?'
I  898.235s run_tests_on_device(01e2f6a326e04093)  tombstone_00 created on 2018-06-19 19:45:00, about this long ago: 0:00:46 Device: 01e2f6a326e04093
I  898.235s run_tests_on_device(01e2f6a326e04093)  Resolving...
I  898.236s run_tests_on_device(01e2f6a326e04093)  [host]> /b/swarming/w/ir/build/android/pylib/symbols/../../../../third_party/android_platform/development/scripts/stack --arch arm64 --output-directory /b/swarming/w/ir/out/Release --more-info /b/swarming/w/itneBF1H/tmpJ7XEHp
W  899.936s tear_down_device(01e2f6a326e04093)  Unable to write device cache as /b/swarming/w/ir/out/Release directory does not exist
I  899.937s Main  Finishing archiving output.
E  899.937s Main  Unrecognized error occurred.
Traceback (most recent call last):
  File "/b/swarming/w/ir/build/android/test_runner.py", line 1042, in main
  File "/b/swarming/w/ir/build/android/test_runner.py", line 745, in RunTestsCommand
  File "/b/swarming/w/ir/build/android/test_runner.py", line 948, in RunTestsInPlatformMode
  File "/b/swarming/w/ir/.swarming_module/lib/python2.7/contextlib.py", line 35, in __exit__
  File "/b/swarming/w/ir/build/android/test_runner.py", line 820, in json_finalizer
OSError: [Errno 2] No such file or directory: '/b/swarming/w/itneBF1H/tmpkGRSe_'
+-----------------------------------------------------------------------------------+
| End of shard 0                                                                    |
|  Pending: 0.4s  Duration: 900.0s  Bot: build314-m1--device7  Exit: -15  TIMED_OUT |
+-----------------------------------------------------------------------------------+
Total duration: 1800.0s
WARNING:root:collect_cmd had non-zero return code: 241
WARNING:root:No shard json files found in task_output_dir: '/tmp/tmpuyQrR9'
Found ['/tmp/tmpuyQrR9/summary.json']
step returned non-zero exit code: 241

This implicates the file web_contents_view_android.cc, which was changed in only one CL in the range where this started failing: https://chromium-review.googlesource.com/1083911

Assigning to jinsukkim@, the author of that CL.

And also reverting in the meantime.

Revert in https://chromium-review.googlesource.com/c/chromium/src/+/1107958.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efb24e491d79b7ba9bf1463dc04a77823b322157

commit efb24e491d79b7ba9bf1463dc04a77823b322157
Author: Martin Šrámek <msramek@chromium.org>
Date: Wed Jun 20 14:08:39 2018

Revert "Android: Delete native ContentViewCore"

This reverts commit e4f3ef2e681d95f396eb33f0ddabcd4148fc84c8.

Reason for revert: Seems to be causing test crashes, and timeouts of entire test suites. See  crbug.com/854611  for more details.

Bug:  598880 , 854611 

Original change's description:
> Android: Delete native ContentViewCore
> 
> The only thing the native CVC does now is (as an WebContentsObserver)
> adjust renderer view focus/screen info when renderer is updated.
> This CL moves that reponsibility to WebContentsAndroid, and deletes
> the entire class. There is no functional change.
> 
> Bug:  598880 
> Change-Id: I9a1f3a2e0df5457439a27675d3786aa6703e06ac
> Reviewed-on: https://chromium-review.googlesource.com/1083911
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568499}

TBR=boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org

Change-Id: I039091e040d468669bd4c5f5b1b42aef9f272d0e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  598880 
Reviewed-on: https://chromium-review.googlesource.com/1107958
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568825}
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/chrome/android/java/src/org/chromium/chrome/browser/content/ContentUtils.java
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/chrome/browser/android/content/content_utils.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/BUILD.gn
[add] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/android/content_view_core.cc
[add] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/android/content_view_core.h
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/media/android/browser_media_player_manager.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/screen_orientation/screen_orientation_delegate_android.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view.h
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_android.h
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_child_frame.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_child_frame.h
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_guest.h
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_mac.h
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/public/android/BUILD.gn
[modify] https://crrev.com/efb24e491d79b7ba9bf1463dc04a77823b322157/content/public/android/java/src/org/chromium/content/browser/ContentViewCoreImpl.java

msramek seems to have handled this -- no further work for sheriffs to do

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/895b2c542855b09bb8e16fdb0d1b282f933fbd34

commit 895b2c542855b09bb8e16fdb0d1b282f933fbd34
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Jul 03 06:49:16 2018

Android: Reland "Delete native ContentViewCore"

Fixes bugs reported after landing:

- Android CFI test failures  https://crbug.com/854611 

WebContentsViewAndroid::SetFocus should have null checks as well, and
should not have run in the tests that use TestRenderViewHost. The
tests failed due to invalid cast (TestRenderWidgetHostView ->
RenderWidgetHostViewAndroid), which was caught by CFI config.

And even in real situation ::SetFocus should run only when
the RenderWidgetHostViewAndroid is not null. These two issues are
addressed by calling the method when current RWHVA is non-null.

- Amazon app not getting key input https://crbug.com/854499

WebContentsViewAndroid::RenderViewSwappedIn and
WebContentsObserver::RenderViewHostchanged were not always called
together. This caused the WebView not to get the updated after the
change.

This CL deletes RenderViewSwappedIn and defines RenderFrameSwappedIn,
and invokes it from WebContentsImpl::NotifyFrameSwapped to ensure native
view tree update + focus change occurs in response to the main render
frame host swapping.

Bug:  598880 ,  854611 , 854499

This reverts commit efb24e491d79b7ba9bf1463dc04a77823b322157.

Change-Id: Ieaa3d43029583a17560dc83b5009416e71e89f13
Reviewed-on: https://chromium-review.googlesource.com/1112950
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572128}
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/chrome/android/java/src/org/chromium/chrome/browser/content/ContentUtils.java
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/chrome/browser/android/content/content_utils.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/BUILD.gn
[delete] https://crrev.com/9be94722d52ede6477bc1c62c2b07fe59ea11bdc/content/browser/android/content_view_core.cc
[delete] https://crrev.com/9be94722d52ede6477bc1c62c2b07fe59ea11bdc/content/browser/android/content_view_core.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/media/android/browser_media_player_manager.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/screen_orientation/screen_orientation_delegate_android.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_android.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_child_frame.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_child_frame.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_guest.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_mac.h
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/public/android/BUILD.gn
[modify] https://crrev.com/895b2c542855b09bb8e16fdb0d1b282f933fbd34/content/public/android/java/src/org/chromium/content/browser/ContentViewCoreImpl.java