New issue
Advanced search Search tips

Issue 854603 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 800418



Sign in to add a comment

Make it easy for developers to use Trusted Web Activities

Project Member Reported by peconn@chromium.org, Jun 20 2018

Issue description

Add convenience classes, documentation, etc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/e8d760cd6e186cbac0807b294cde685ffc6b5968

commit e8d760cd6e186cbac0807b294cde685ffc6b5968
Author: Peter E Conn <peconn@chromium.org>
Date: Mon Jun 25 09:18:02 2018

🤝 Allow developers to create TWAs easily with LauncherActivity.

Add the LauncherActivity class which will allow developers to create a
Trusted Web Activity client app that will verify and launch a Trusted
Web Activity without writing any Java code - only by configuring their
manifest.

Bug: 854603
Change-Id: Iac0baf681d38f516e3cea72c4491f6c3eaf7ee14
Reviewed-on: https://chromium-review.googlesource.com/1107924
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>

[modify] https://crrev.com/e8d760cd6e186cbac0807b294cde685ffc6b5968/customtabs/src/android/support/customtabs/TrustedWebUtils.java
[modify] https://crrev.com/e8d760cd6e186cbac0807b294cde685ffc6b5968/svgomg/src/main/AndroidManifest.xml
[add] https://crrev.com/e8d760cd6e186cbac0807b294cde685ffc6b5968/customtabs/src/android/support/customtabs/trusted/LauncherActivity.java
[delete] https://crrev.com/dde0cb7b054b212d7f2afad9606de23d00ed0c3b/svgomg/src/main/java/org/chromium/twa/svgomg/TwaSessionHelper.java
[delete] https://crrev.com/dde0cb7b054b212d7f2afad9606de23d00ed0c3b/svgomg/src/main/java/org/chromium/twa/svgomg/TwaLauncherActivity.java
[modify] https://crrev.com/e8d760cd6e186cbac0807b294cde685ffc6b5968/svgomg/build.gradle

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/255d0a36b35fa38c19f935d9edd64143c4244f2f

commit 255d0a36b35fa38c19f935d9edd64143c4244f2f
Author: Peter E Conn <peconn@chromium.org>
Date: Tue Jul 10 09:03:18 2018

🤝 Make LauncherActivity ephemeral.

This prevents it from hanging around in Recents and manages its
connection to the custom tabs service better.

Bug: 854603
Change-Id: I7828c985a7a01f4e7139574695c316e1e39ba99a
Reviewed-on: https://chromium-review.googlesource.com/1128961
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>

[modify] https://crrev.com/255d0a36b35fa38c19f935d9edd64143c4244f2f/customtabs/src/android/support/customtabs/trusted/LauncherActivity.java

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1801fee6135b489579ca30109ed1e9cc05a097af

commit 1801fee6135b489579ca30109ed1e9cc05a097af
Author: Peter E Conn <peconn@chromium.org>
Date: Tue Nov 20 13:43:05 2018

🤝 Roll Custom Tabs Library version.

It appears that changes to custom-tabs-client code are not synced to
https://github.com/GoogleChrome/custom-tabs-client until they are
included in Chrome's DEPS.

This rolls the custom tabs client code to include fixes to a Trusted
Web Activity utility class and to make it build with Java 8 (it was
previously using Java 8 features, so technically this is a fix).

Bug: 854603
Change-Id: I0937d2ed077cdf716293182c8b1bac6ef0895534
Reviewed-on: https://chromium-review.googlesource.com/c/1337489
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609683}
[modify] https://crrev.com/1801fee6135b489579ca30109ed1e9cc05a097af/DEPS

Sign in to add a comment