New issue
Advanced search Search tips

Issue 854602 link

Starred by 2 users
Status: Duplicate
Merged: issue 851044
Owner: ----
Closed: Jun 2018
Cc:
ellyjo...@chromium.org
pkasting@chromium.org
bettes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MdRefresh] New Tab Button could be aligned with the Settings Button

Project Member Reported by meh...@chromium.org, Jun 20 2018 
Chrome Version: Canary 69.0.3466.0
OS: macOS 10.13.4

What steps will reproduce the problem?
(1) Enable #upcoming-ui-features
(1) Compare the position of the New Tab Button with the Toolbar's Settings Button


What is the expected result?
It would be nice, if both hover states could be aligned vertically.

What happens instead?
The New Tab Button is some pixels too far right and it is not aligned with the Toolbar's Settings Button.

Screenshots are attached.

Thanks,
Mehmet
Actual_Hover_States.png
22.1 KB View Download
Expected_Aligned_Hover_States.png
22.7 KB View Download

Comment 1 by lgrey@chromium.org, Jun 20 2018

Cc: bettes@chromium.org
bettes@, WDYT?

Comment 2 by pkasting@chromium.org, Jun 20 2018 

This is likely a dupe of  bug 851044  -- I don't think the current padding actually matches the spec, and I suspect if we do match the spec things will line up.  With a non-zoomed screenshot I could probably tell you.

Comment 3 by meh...@chromium.org, Jun 20 2018 

> This is likely a dupe of  bug 851044  -- I don't think the current padding actually matches the spec, and I suspect if we do match the spec things will line up.  With a non-zoomed screenshot I could probably tell you.

Please find attached the non-zoomed screenshots of the Hovered_NewTabButton and the Hovered_Settings_Button.

Thanks.
Hovered_NewTabButton.png
117 KB View Download
Hovered_Settings_Button.png
117 KB View Download

Comment 4 by pkasting@chromium.org, Jun 20 2018

Mergedinto: 851044
Status: Duplicate (was: Untriaged)
Yep, this is a dupe.  The screenshot padding of the NTB is 4 DIP; the spec is 8 DIP, and the screenshot of the settings button is 8 DIP, so when that is fixed, these should match.

Comment 5 by meh...@chromium.org, Jun 20 2018 

Great, thank you for checking it :)
►

Sign in to add a comment