New issue
Advanced search Search tips

Issue 854594 link

Starred by 1 user
Status: Fixed
Owner:
alexilin@chromium.org
Closed: Oct 18
Cc:
mattcary@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 795291



Sign in to add a comment

Convert gfx::GpuMemoryBufferHandle to the new shared memory API

Project Member Reported by alexilin@chromium.org, Jun 20 2018 
The deprecated SharedMemoryHandle is used in ui/gfx/gpu_memory_buffer.h.

This struct may hold different types of handles, including SharedMemoryHandle. In order to use a shared memory region instead of the SharedMemoryHandle, we need to make this class move-only because a shared memory region cannot be copied. 

The problem is that GpuMemoryBufferHandle owns the underlying handle in some cases and in some cases it doesn't. Since this object is transferred across processes, it would be safer and less error-prone to make it owning. Constant reference could be used in cases, when the GpuMemoryBufferHandle isn't owning.

This change will mainly affect the code in the following directories:
* ui/gfx
* ui/gl
* gpu/ipc/common

Comment 1 by mattcary@chromium.org, Jun 20 2018 

My experience with the BitstreamBuffer/VideoFrame conversion suggests that you'll also have to add some Duplicate() calls as well. I'll be interested to see how it turns out.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb

commit d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Mon Jun 25 17:47:38 2018

gfx: Make GpuMemoryBufferHandle move-only.

This CL removes the copy constructor from the gfx::GpuMemoryBufferHandle
replacting it with move operations. This is preparatory step to make
GpuMemoryBufferHandle using the new shared memory classes that are move-only.

GpuMemoryBufferHandle holds a system resource that should be properly closed
after use. Move semantics allow to introduce the more clear ownership model
and prevent resource leaks.

Bug:  854594 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I27907d7a8b09aa4003de2c846966bf7d97aaa30c
Reviewed-on: https://chromium-review.googlesource.com/1109972
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570087}
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/components/exo/shared_memory.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/components/viz/host/server_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/components/viz/host/server_gpu_memory_buffer_manager.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/components/viz/host/server_gpu_memory_buffer_manager_unittest.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/components/viz/service/display_embedder/in_process_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/content/browser/gpu/browser_gpu_memory_buffer_manager.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/content/browser/gpu/gpu_client_impl.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/content/browser/gpu/gpu_client_impl.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/gpu/ipc/client/command_buffer_proxy_impl.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/gpu/ipc/common/gpu_memory_buffer_impl_test_template.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/gpu/ipc/common/gpu_memory_buffer_support.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/gpu/ipc/common/gpu_memory_buffer_support.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/media/capture/video/chromeos/local_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/media/capture/video/mock_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/services/ui/public/cpp/gpu/client_gpu_memory_buffer_manager.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/ui/gfx/gpu_memory_buffer.cc
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/ui/gfx/gpu_memory_buffer.h
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/ui/gfx/mojo/buffer_types.typemap
[modify] https://crrev.com/d82fcd88bbaa1548b12c1d3f65d51e64ff907ebb/ui/gfx/mojo/struct_traits_unittest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e06eb30e11fc66f5f1472cb5d605c66c047adac

commit 1e06eb30e11fc66f5f1472cb5d605c66c047adac
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Mon Jul 02 14:00:43 2018

base: Add GetGUID() method to shared memory region classes

Some clients would like to get a unique shared memory region ID without having
a mapping to this region. There is no reason to not expose this method that is
already implemented in the PlatformSharedMemoryRegion.

Bug:  854594 
Change-Id: I7e7de1b6c35748c382a1bf99974c53a0472e9b73
Reviewed-on: https://chromium-review.googlesource.com/1117190
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571884}
[modify] https://crrev.com/1e06eb30e11fc66f5f1472cb5d605c66c047adac/base/memory/read_only_shared_memory_region.h
[modify] https://crrev.com/1e06eb30e11fc66f5f1472cb5d605c66c047adac/base/memory/shared_memory_region_unittest.cc
[modify] https://crrev.com/1e06eb30e11fc66f5f1472cb5d605c66c047adac/base/memory/unsafe_shared_memory_region.h
[modify] https://crrev.com/1e06eb30e11fc66f5f1472cb5d605c66c047adac/base/memory/writable_shared_memory_region.h

Comment 4 by alexilin@chromium.org, Jul 5

Blocking: 795291
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0443a8fb9e6e862ee70aea4644eeea5297334416

commit 0443a8fb9e6e862ee70aea4644eeea5297334416
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Fri Jul 20 20:14:50 2018

gfx: Improve handle management in gfx::GpuMemoryBuffer

The handle returned from gfx::GpuMemoryBuffer::GetHandle() is either passed to
CloneHandleForIPC immediately or used to obtain some handle metadata (type,
GUID).

This CL replaces GpuMemoryBuffer::GetHandle() with the new method
GpuMemoryBuffer::CloneHandle() that is equivalent of calling
CloneHandleForIPC(buffer.GetHandle()). This will allow to use scoped objects for
all types of underlying platform handles, since no two GpuMemoryBufferHandles
will refer to the same system resource. New methods are also added to access
type/GUID of buffer.

As a demonstration, this CL changes the type of the
GpuMemoryBufferHandle::android_hardware_buffer from AHardwareBuffer* to
base::android::ScopedHardwareBufferHandle.

Bug:  854594 , 863011
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0306f4295cf28113cf467dba3c2a2b1717ca2e67
Reviewed-on: https://chromium-review.googlesource.com/1126394
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576964}
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/layers/heads_up_display_layer_impl.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/resources/resource_pool.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/resources/resource_pool.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/resources/resource_pool_unittest.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/test/fake_raster_buffer_provider.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/test/test_image_factory.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/test/test_image_factory.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/chrome/browser/android/vr/arcore_device/ar_image_transport.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/components/viz/service/display_embedder/buffer_queue_unittest.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/components/viz/test/test_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/command_buffer/service/image_factory.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/command_buffer/tests/gl_manager.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/command_buffer/tests/texture_image_factory.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/command_buffer/tests/texture_image_factory.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/client/command_buffer_proxy_impl.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_android_hardware_buffer.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_android_hardware_buffer.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_dxgi.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_dxgi.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_io_surface.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_io_surface.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_native_pixmap.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_native_pixmap.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/command_buffer_stub.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/command_buffer_stub.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_channel.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_memory_buffer_factory_android_hardware_buffer.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_memory_buffer_factory_android_hardware_buffer.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_memory_buffer_factory_dxgi.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_memory_buffer_factory_dxgi.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_memory_buffer_factory_io_surface.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_memory_buffer_factory_io_surface.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/ipc/ipc_message_utils.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/ipc/ipc_message_utils.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/media/capture/video/chromeos/local_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/media/capture/video/chromeos/stream_buffer_manager.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/media/capture/video/mock_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/media/video/mock_gpu_video_accelerator_factories.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/third_party/blink/renderer/platform/graphics/gpu/xr_frame_transport.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/ui/gfx/gpu_memory_buffer.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/ui/gfx/gpu_memory_buffer.h
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/ui/gfx/mojo/buffer_types_struct_traits.cc
[modify] https://crrev.com/0443a8fb9e6e862ee70aea4644eeea5297334416/ui/gfx/mojo/buffer_types_struct_traits.h
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f

commit 81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f
Author: Alexandr Ilin <alexilin@chromium.org>
Date: Thu Oct 18 08:30:34 2018

gfx: Convert gfx::GpuMemoryBufferHandle to the new shared memory API.

This CL replaces the deprecated base::SharedMemoryHandle in
gfx::GpuMemoryBufferHandle with the base::UnsafeSharedMemoryRegion.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I527a84876f8b87ddc652cf2f780a2893cb419c46
Bug:  854594 , 863011
Reviewed-on: https://chromium-review.googlesource.com/c/1106340
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600693}
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/cc/test/test_image_factory.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/exo/display.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/exo/display.h
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/exo/display_unittest.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/exo/shared_memory.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/exo/shared_memory.h
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/exo/shared_memory_unittest.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/exo/wayland/server.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/viz/host/host_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/components/viz/test/test_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/gpu/ipc/common/gpu_memory_buffer_impl_shared_memory.h
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gfx/gpu_memory_buffer.h
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gfx/ipc/gfx_param_traits_macros.h
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gfx/mojo/buffer_types.mojom
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gfx/mojo/buffer_types_struct_traits.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gfx/mojo/buffer_types_struct_traits.h
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gfx/mojo/struct_traits_unittest.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gl/gl_image_shared_memory.cc
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gl/gl_image_shared_memory.h
[modify] https://crrev.com/81c4128e3f75163f0a99c021c3bfc8ce5c0d7a0f/ui/gl/gl_image_shared_memory_unittest.cc

Comment 7 by alexilin@chromium.org, Oct 18

Status: Fixed (was: Started)
The conversion is done. There may be follow-up introducing ReadOnly regions to GpuMemoryBufferHandle, but this is out of scope of this issue.
►

Sign in to add a comment