New issue
Advanced search Search tips

Issue 854577 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

The experimental native echo canceller origin trial has the wrong OT flag name

Project Member Reported by ossu@chromium.org, Jun 20 2018

Issue description

It's currently reusing the same OT flag as the previous trial, which could cause new OT tokens to trigger the old behavior in old browsers. It should be renamed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a07689aec111f6af8a2de242765647f95a0f09

commit 65a07689aec111f6af8a2de242765647f95a0f09
Author: Oskar Sundbom <ossu@chromium.org>
Date: Wed Jun 20 13:45:23 2018

Rename the ExperimentalHardwareEchoCancellation origin trial

Renaming it to ExperimentalHardwareEchoCancellation2, so that new
tokens don't trigger the old behaviour in older versions of Chrome.

The runtime flag retains its name, since that's user controlled.

Bug:  854577 ,  846270 
Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131
Reviewed-on: https://chromium-review.googlesource.com/1106338
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568821}
[modify] https://crrev.com/65a07689aec111f6af8a2de242765647f95a0f09/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 2 by ossu@chromium.org, Jun 20 2018

Labels: Merge-Request-68
Requesting merge of the change in #1 to M68. It's just a simple name change.

Comment 3 by ossu@chromium.org, Jun 21 2018

Cc: grunell@chromium.org
This one's waiting for merge approval. Please keep an eye on it if I'm unable to get it merged before going on vacation.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 21 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Which OS's is this impacting?
Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Started)
It impacts all platforms in the sense that the origin trial exposes an experimental constraint field in the WebRTC API. That constraint however will currently only affect Windows and Mac.
Labels: -Merge-Review-68 Merge-Approved-68
Approved: branch:3440
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 27 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77ea8ef8fabc87461b67c653f12eefb0273bae80

commit 77ea8ef8fabc87461b67c653f12eefb0273bae80
Author: Oskar Sundbom <ossu@chromium.org>
Date: Wed Jun 27 07:23:12 2018

Rename the ExperimentalHardwareEchoCancellation origin trial

Renaming it to ExperimentalHardwareEchoCancellation2, so that new
tokens don't trigger the old behaviour in older versions of Chrome.

The runtime flag retains its name, since that's user controlled.

Bug:  854577 ,  846270 
Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131
Reviewed-on: https://chromium-review.googlesource.com/1106338
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#568821}(cherry picked from commit 65a07689aec111f6af8a2de242765647f95a0f09)
Reviewed-on: https://chromium-review.googlesource.com/1116578
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#547}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/77ea8ef8fabc87461b67c653f12eefb0273bae80/third_party/blink/renderer/platform/runtime_enabled_features.json5

Sign in to add a comment