The experimental native echo canceller origin trial has the wrong OT flag name |
|||||||
Issue descriptionIt's currently reusing the same OT flag as the previous trial, which could cause new OT tokens to trigger the old behavior in old browsers. It should be renamed.
,
Jun 20 2018
Requesting merge of the change in #1 to M68. It's just a simple name change.
,
Jun 21 2018
This one's waiting for merge approval. Please keep an eye on it if I'm unable to get it merged before going on vacation.
,
Jun 21 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 25 2018
Which OS's is this impacting?
,
Jun 26 2018
It impacts all platforms in the sense that the origin trial exposes an experimental constraint field in the WebRTC API. That constraint however will currently only affect Windows and Mac.
,
Jun 26 2018
Approved: branch:3440
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77ea8ef8fabc87461b67c653f12eefb0273bae80 commit 77ea8ef8fabc87461b67c653f12eefb0273bae80 Author: Oskar Sundbom <ossu@chromium.org> Date: Wed Jun 27 07:23:12 2018 Rename the ExperimentalHardwareEchoCancellation origin trial Renaming it to ExperimentalHardwareEchoCancellation2, so that new tokens don't trigger the old behaviour in older versions of Chrome. The runtime flag retains its name, since that's user controlled. Bug: 854577 , 846270 Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131 Reviewed-on: https://chromium-review.googlesource.com/1106338 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568821}(cherry picked from commit 65a07689aec111f6af8a2de242765647f95a0f09) Reviewed-on: https://chromium-review.googlesource.com/1116578 Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#547} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/77ea8ef8fabc87461b67c653f12eefb0273bae80/third_party/blink/renderer/platform/runtime_enabled_features.json5 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jun 20 2018