Regression : Grey focus highlight is not seen on check box in chrome://settings/languages.
Reported by
rp...@etouch.net,
Jun 20 2018
|
||||||
Issue descriptionChrome version: 68.0.3440.33 (Official Build)Revision d62017a8f8d8d64411d2c510a5355c88b0cf9671-refs/branch-heads/3440@{#460}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.5) What steps will reproduce the problem? 1. Launch chrome,navigate to chrome://settings/languages 2. Now expand 'Language' and click on 'Add languages' to open overlay 3. Now scroll down the language item list using mouse wheel and click on check box of any language to check and then uncheck the same 4. Now scroll up the language item list using mouse wheel and click on 'Search languages' text field and then press tab key,observe focus Actual: Grey focus highlight is not seen on check box Expected: Grey focus highlight should be seen on check box This is regression issue, broken in ‘M 68’ and below is the bisect info : Good build: 68.0.3400.0 (Revision: 551876). Bad build: 68.0.3401.0 (Revision: 552221). You are probably looking for a change made after 552148 (known good), but no later than 552149 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/54d6ad62258f03e21bf918d647686bd7b8aa4d15..9417cbbdf2bf0fb3b82cc20e0b0e5cd808d71b16 Suspect : https://chromium.googlesource.com/chromium/src/+/9417cbbdf2bf0fb3b82cc20e0b0e5cd808d71b16 From the CL above, assigning the issue to the concern owner @scottchen- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : Above issue is also seen on M-69 Dev build 69.0.3464.0 and M-69 Canary Build : 69.0.3466.0
,
Jun 26 2018
Issue 674017 has been merged into this issue.
,
Jun 29 2018
Seems to be a bug introduced in the newer version of iron-list. I dug around for 2 days and wasn't able to get much further so I created a minimum repro in jsfiddle and filed a bug, along with all my findings. https://github.com/PolymerElements/iron-list/issues/537
,
Jul 12
update: tried the fix that was committed to iron-list repo and it does fix our issue, so now we're just waiting for a new version to be released.
,
Jul 12
update: we'll patch this locally first, and roll to the next version of iron-list when it gets released.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8119ab89829fd67673aa383bdfd013181cc9d284 commit 8119ab89829fd67673aa383bdfd013181cc9d284 Author: Scott Chen <scottchen@chromium.org> Date: Fri Jul 13 21:34:04 2018 Settings: fix issue with add-language dialog check-boxes lose focus. <iron-list> introduced a bug that causes a focused item to lose focus when the user scrolls away then tab back. A fix was landed in the iron-list repository but a new version had not been released yet, so this CL patches the fix locally first. The local patch should be removed later once iron-list releases the new version and is patched into our code-base. Bug: 854571 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5b70ce4188b882839e7a322270847fde85690011 Reviewed-on: https://chromium-review.googlesource.com/1135652 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575077} [modify] https://crrev.com/8119ab89829fd67673aa383bdfd013181cc9d284/third_party/polymer/v1_0/chromium.patch [modify] https://crrev.com/8119ab89829fd67673aa383bdfd013181cc9d284/third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js
,
Jul 14
,
Jul 16
Update : Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS with latest Canary Chrome version : 69.0.3493.0 and the issue is Fixed.Kindly refer the attached screen cast for reference. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by scottchen@chromium.org
, Jun 20 2018