New issue
Advanced search Search tips

Issue 854566 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Blue focus ring is not seen by default on Cancel/Print button on Print overlay

Reported by vineetha...@etouch.net, Jun 20 2018

Issue description

Chrome Version: 68.0.3440.33 (Official Build) Revision d62017a8f8d8d64411d2c510a5355c88b0cf9671-refs/branch-heads/3440@{#460}(32/64 bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6 , 10.13.1 , 10.13.5, 10.13.6) and Linux(14.04)

Pre-condition: Enable 'Enable new Print Preview UI' flag under chrome://flags

What steps will reproduce the problem?
(1) Launch chrome, open NTP. 
(2) Press Ctrl+P to open print preview overlay and observe.

Actual  : Blue focus ring is not seen on either Cancel/Print button by default.
Expected: Blue focus ring should be seen by default on Cancel/Print button.

This is a non-regression issue, seen from M67

 
ActualVideo.mp4
436 KB View Download
Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!
Owner: rbpotter@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa9b50af4624f43809216b90c8c15b9390bd3edd

commit aa9b50af4624f43809216b90c8c15b9390bd3edd
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Jun 22 00:54:29 2018

Print Preview Componentization: Automatically focus Print button

Copy the existing UI behavior of focusing the print button when a new
destination is ready, including on initialization.

Bug:  854566 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I517340b31e4d7e4550b894788ae7339599b292e6
Reviewed-on: https://chromium-review.googlesource.com/1108755
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569477}
[modify] https://crrev.com/aa9b50af4624f43809216b90c8c15b9390bd3edd/chrome/browser/resources/print_preview/new/header.js

Update :
Rechecked the above issue on , Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) and Linux(14.04) OS with latest Canary Chrome version #69.0.3469.2, and on Windows(7,8,8.1,10) OS with latest Canary Chrome version #69.0.3469.3 and the issue is still reproducible.

Kindly refer the attached screen cast.
CanaryBehaviour.mp4
547 KB View Download
This needs to be tested with 69.0.3470.0 or higher.
Labels: TE-Verified-M69 TE-Verified-69.0.3472.0
Update :
Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.5, 10.13.6) and Linux(14.04) OS with latest Canary Chrome version #69.0.3472.0 and the issue is fixed.

Kindly refer the attached screen cast.
CanaryBehaviour.mp4
399 KB View Download
Status: Fixed (was: Started)

Sign in to add a comment