New issue
Advanced search Search tips

Issue 854565 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 874753



Sign in to add a comment

CSS Grid layout is not applied to <fieldset> elements

Reported by final.te...@gmail.com, Jun 20 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3464.2 Safari/537.36

Steps to reproduce the problem:
1. Build a <fieldset> element and try to set `display:grid` onto it
2. It’s not applied but also not reported wrong.

What is the expected behavior?
CSS Grid layout should be applied to fieldset elements as well. If not, it should at least tell me so in the DevTools and strikethrough and link to this bug report here.

What went wrong?
No grid layout is applied to fieldsets. There’s nothing in the spec that says this is valid so I’m filing this bug.

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 69.0.3464.2  Channel: canary
OS Version: OS X 10.13.5
Flash Version:
 
chromium-css-grid-layout-fieldset-test-case.html
470 bytes View Download
Components: Blink>Layout
Labels: Needs-Triage-M69
Labels: Triaged-ET M-69 Target-69 FoundIn-69 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.13.3, Win-10 and Ubuntu 17.10 using chrome reported version #69.0.3464.2.
This is a non-regression issue as it is observed from M60 old builds. 

Hence, marking it as untriaged to get more inputs from dev team.

Thanks...!!

Comment 4 by e...@chromium.org, Jun 28 2018

Cc: mstensho@chromium.org
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)
We just ignore the display type completely and create a LayoutFieldSet, which is just a special block flow container.

I can't find anything in the spec that suggests that other display types should be ignored, but I also have a hard time imagining how this is supposed to work together with a LEGEND child. I see that Firefox, but not Edge, supports display:grid on FIELDSET (even with a LEGEND). Flexbox is also supported. Tables, on the other hand, are not.

Comment 6 by emilio@chromium.org, Jun 29 2018

FWIW, Firefox implements <fieldset> with an anonymous block + the legend.

We special-case some display types so they apply to the anonymous block (grid and flex, basically): https://searchfox.org/mozilla-central/rev/d2966246905102b36ef5221b0e3cbccf7ea15a86/servo/components/style/style_adjuster.rs#476
Components: -Blink>Layout Blink>Layout>Grid
Components: Blink>Forms>Fieldset
Blocking: 874753
BTW, this has been fixed in WebKit more than 1 year ago:
https://bugs.webkit.org/show_bug.cgi?id=169082

Just in case a similar approach can be valid for Blink too.

Sign in to add a comment