New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 854562 link

Starred by 1 user
Status: Fixed
Owner:
jdoerrie@chromium.org
Closed: Jun 2018
Cc:
maxwalker@chromium.org
█ nepper@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Task

Blocking:
issue 854561



Sign in to add a comment

[MD-Settings] Implement required changes for Autofill Home

Project Member Reported by jdoerrie@chromium.org, Jun 20 2018 
This bug serves as a tracking bug for the MD-Settings changes required by the new Autofill Home (go/autofill-home). In particular, the following changes are required:

1) Update the passwords and autofill section titles
2) Update the entry points to the new titles, add icons and split autofill in addresses and credit cards
3) Move "Passwords", "Credit cards" and "Addresses" from the advanced settings to the more prominent "People" section

Comment 1 by jdoerrie@chromium.org, Jun 20 2018

Blocking: 854561
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c01ae96cf3f38ef8ca9c38440ebb66b90a26fc1a

commit c01ae96cf3f38ef8ca9c38440ebb66b90a26fc1a
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Jun 20 13:59:56 2018

Land the strings for Autofill home.

Bug:  854562 
Change-Id: Id61eee835d304369c9efb19dafbcb29b3b6f4195
Reviewed-on: https://chromium-review.googlesource.com/1107814
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568824}
[modify] https://crrev.com/c01ae96cf3f38ef8ca9c38440ebb66b90a26fc1a/chrome/app/generated_resources.grd

Comment 3 by vasi...@chromium.org, Jun 20 2018

Screenshot from 2018-06-20 17-00-44.png
24.4 KB View Download
Screenshot from 2018-06-20 17-00-37.png
19.4 KB View Download

Comment 4 by nepper@chromium.org, Jun 21 2018 

Awesome, thanks for the screenshots. FYI, in case anyone is dropping in: Vasilii is currently looking into changing the location icon to the intended icon (a pin).

Otherwise, looks cool! :)

Comment 5 by vasi...@chromium.org, Jun 21 2018 

I changed it.
Screenshot from 2018-06-21 13-01-11.png
19.0 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce8fa29b1bbec10e9b98e06f2b8dcd831b8a25b6

commit ce8fa29b1bbec10e9b98e06f2b8dcd831b8a25b6
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Jun 21 13:06:25 2018

Add autofill home entries to the profile menu.

The profile avatar opens the Chrome profile menu. This change adds 3 new menu items there.
- Passwords -> chrome://settings/passwords
- Payment methods -> chrome://settings/autofill
- Addresses -> chrome://settings/autofill
It's expected for M69 that Payment methods and Addresses link to the same page.
The icon for addresses is just temporary.

Bug:  854562 
Change-Id: I7f5b62914e49b8e3ae9d882a7d6eaaf05a532100
Reviewed-on: https://chromium-review.googlesource.com/1108097
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569231}
[modify] https://crrev.com/ce8fa29b1bbec10e9b98e06f2b8dcd831b8a25b6/chrome/app/generated_resources.grd
[modify] https://crrev.com/ce8fa29b1bbec10e9b98e06f2b8dcd831b8a25b6/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/ce8fa29b1bbec10e9b98e06f2b8dcd831b8a25b6/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/ce8fa29b1bbec10e9b98e06f2b8dcd831b8a25b6/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/ce8fa29b1bbec10e9b98e06f2b8dcd831b8a25b6/components/password_manager/core/common/password_manager_features.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83aaf143874b51843b67663277251ab9e55e78cc

commit 83aaf143874b51843b67663277251ab9e55e78cc
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Jun 21 20:30:56 2018

[Autofill Home] Add Required Settings Strings

This change adds required settings strings for Autofill Home. No further
functionality is added.

Bug:  854562 
Change-Id: Id8165651b2484f58818e218c81a4a457cbeda2e3
Reviewed-on: https://chromium-review.googlesource.com/1109680
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569375}
[modify] https://crrev.com/83aaf143874b51843b67663277251ab9e55e78cc/chrome/app/settings_strings.grdp
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e381320005d723ce1f0cdc952060c81938e0e83

commit 5e381320005d723ce1f0cdc952060c81938e0e83
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Jun 22 10:26:58 2018

[Autofill Home] Update Passwords and Autofill Section Headers

This change updates the section headers of the passwords and autofill
section to reflect the Autofill Home proposal

Bug:  854562 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: If582fadf067ad02b1a5642aca8f6f5083497e37e
Reviewed-on: https://chromium-review.googlesource.com/1107704
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569569}
[modify] https://crrev.com/5e381320005d723ce1f0cdc952060c81938e0e83/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e39ecde47cb3d28989cb3b44c106ec36ea28254

commit 9e39ecde47cb3d28989cb3b44c106ec36ea28254
Author: jdoerrie <jdoerrie@chromium.org>
Date: Fri Jun 22 10:34:11 2018

[Autofill Home] Use Sentence Case in Autofill Title

This CL changes the title of the autofill section to use sentence case.

TBR=hcarmona

Bug:  854562 
Change-Id: I362f8516bd2854f3f6a65ccf5790b3d1f06456f8
Reviewed-on: https://chromium-review.googlesource.com/1111713
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569571}
[modify] https://crrev.com/9e39ecde47cb3d28989cb3b44c106ec36ea28254/chrome/app/settings_strings.grdp

Comment 10 by vasi...@chromium.org, Jun 22 2018 

Dice
Screenshot from 2018-06-22 13-54-03.png
22.2 KB View Download
Screenshot from 2018-06-22 13-52-13.png
23.1 KB View Download

Comment 11 by jdoerrie@chromium.org, Jun 22 2018

People_Page.png
47.7 KB View Download
Autofill_Settings.png
39.8 KB View Download

Comment 12 by nepper@chromium.org, Jun 22 2018 

Wohoo Jan! Really looking forward to seeing this in Canary next week :D
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b40f8ffd59a0be7d2cabede58aba4361ad737c0

commit 9b40f8ffd59a0be7d2cabede58aba4361ad737c0
Author: Jan Wilken Doerrie <jdoerrie@chromium.org>
Date: Thu Jun 28 11:27:38 2018

[Autofill Home] Add New Entry Points and Icons

This change implement adding new entry points for the new Autofill Home.
Also it adds the required icons. Both of these changes are gated behind
a flag.

Bug:  854562 
Change-Id: Iee5b029045b59875ad4d98bffb856ddc9945171a
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1111853
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571079}
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/test/data/webui/settings/a11y/passwords_a11y_test.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/test/data/webui/settings/advanced_page_browsertest.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/chrome/test/data/webui/settings/settings_menu_test.js
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
[modify] https://crrev.com/9b40f8ffd59a0be7d2cabede58aba4361ad737c0/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.js

Comment 14 by jdoerrie@chromium.org, Jun 28 2018

Status: Fixed (was: Assigned)

Comment 15 by jdoerrie@chromium.org, Jul 3 

Screenshots for code review.
Before_People.png
26.5 KB View Download
After_People.png
26.5 KB View Download
Before_Zoom.png
6.8 KB View Download
After_Zoom.png
5.6 KB View Download

Comment 16 by maxwalker@chromium.org, Jul 3 

Looks great, thanks Jan!

Comment 17 by vasi...@chromium.org, Jul 4 

Padding corrected
Screenshot from 2018-07-04 15-21-11.png
25.8 KB View Download
Screenshot from 2018-07-04 15-21-13.png
25.7 KB View Download

Comment 18 by nepper@chromium.org, Jul 4 

Max, sorry for the drive-by: Is it just me or is the key (even the straight horizontal part of it) more dithered than the credit card icon?

Comment 19 by maxwalker@chromium.org, Jul 4 

Yah, unfortunately all icons in the user menu have incorrect sizes (is: 20dp, should be: 16dp), see: https://bugs.chromium.org/p/chromium/issues/detail?id=856662.

Vasilii, could you use the 20dp assets that are being used in Settings so we get sharp icons until the broader issue gets fixed (might be after M69)?
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c62ed8f27f91bd3c736ded1c8058335fcabab02

commit 4c62ed8f27f91bd3c736ded1c8058335fcabab02
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Jul 06 19:26:37 2018

Add padding before and after Autofill Home on desktop.

Bug:  854562 
Change-Id: I5f40bda74fd1a8b8c75225cf38c0f3a019d89c86
Reviewed-on: https://chromium-review.googlesource.com/1126110
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573042}
[modify] https://crrev.com/4c62ed8f27f91bd3c736ded1c8058335fcabab02/chrome/browser/ui/views/profiles/profile_chooser_view.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a245b973dc16f05b41f37de2933a2af30fe278b6

commit a245b973dc16f05b41f37de2933a2af30fe278b6
Author: jdoerrie <jdoerrie@chromium.org>
Date: Mon Jul 16 10:23:47 2018

[Autofill Home] Sharpen Icons at 20px

This change replaces the Autofill Home icons introduced in r571079 with
icons optimized for rendering at 20px.

Bug:  854562 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I4b1d521d004fe16087094b132ccebc74c5a33420
Reviewed-on: https://chromium-review.googlesource.com/1124165
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575217}
[modify] https://crrev.com/a245b973dc16f05b41f37de2933a2af30fe278b6/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/a245b973dc16f05b41f37de2933a2af30fe278b6/chrome/browser/resources/settings/people_page/people_page.html
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbd05438b3ddb1cf2511e67947dcc503070f1e00

commit bbd05438b3ddb1cf2511e67947dcc503070f1e00
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Oct 23 22:12:38 2018

Delete password_manager::features::kAutofillHome flag from the native UI.

It's fully launched.

Bug:  854562 
Change-Id: Iae62096ced27a37cd29e18db405842f13fa6ff71
Reviewed-on: https://chromium-review.googlesource.com/c/1288973
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602127}
[modify] https://crrev.com/bbd05438b3ddb1cf2511e67947dcc503070f1e00/chrome/browser/ui/views/profiles/profile_chooser_view.cc
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38d2033c0f32eb34cb03791579b1c2b47db36888

commit 38d2033c0f32eb34cb03791579b1c2b47db36888
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Fri Nov 30 03:28:00 2018

[Settings WebUI] Introduce Autofill Section

This change introduces a new Autofill section into the Chrome settings
UI. This section contains "Passwords", "Payment Methods" and "Addresses
and more", which prior to this change were part of the People section.
In particular, this change:

- Renames passwords_and_forms_page to autofill_page
- Moves autofill entries from people_page.html to autofill_page.html
- Adds a chrome://settings/autofill route for the new section, renaming
  the previously existing autofill route to chrome://settings/addresses
- Removes the kAutofillHome feature flag and related conditionals
- Removes a few now obsolete strings from settings_strings.grdp

Bug: 907035,  854562 
Change-Id: I479841db651c23813ab1ac1525f712d0ff9266c2
Reviewed-on: https://chromium-review.googlesource.com/c/1348039
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612541}
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/app/settings_strings.grdp
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/BUILD.gn
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/BUILD.gn
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/address_edit_dialog.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/address_edit_dialog.js
[add] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/autofill_browser_proxy.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/autofill_browser_proxy.js
[add] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/autofill_page.html
[add] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/autofill_page.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/autofill_section.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/autofill_section.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/credit_card_edit_dialog.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/credit_card_edit_dialog.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/password_edit_dialog.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/password_edit_dialog.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/password_list_item.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/password_list_item.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/password_manager_proxy.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/password_manager_proxy.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/passwords_export_dialog.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/passwords_export_dialog.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/passwords_section.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/passwords_section.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/passwords_shared_css.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/payments_section.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/payments_section.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/show_password_behavior.html
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/autofill_page/show_password_behavior.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/lazy_load.html
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/page_visibility.js
[delete] https://crrev.com/6846037efcaf321e0b552dae5c6c07f8c576e872/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[delete] https://crrev.com/6846037efcaf321e0b552dae5c6c07f8c576e872/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/people_page/BUILD.gn
[delete] https://crrev.com/6846037efcaf321e0b552dae5c6c07f8c576e872/chrome/browser/resources/settings/people_page/people_browser_proxy.html
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/common/webui_url_constants.h
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/test/data/webui/settings/a11y/passwords_a11y_test.js
[rename] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/test/data/webui/settings/autofill_browsertest.js
[add] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/test/data/webui/settings/autofill_page_test.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/components/password_manager/core/common/password_manager_features.h
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter
[modify] https://crrev.com/38d2033c0f32eb34cb03791579b1c2b47db36888/testing/buildbot/filters/webui_polymer2_browser_tests.filter
Project Member

Comment 24 by bugdroid1@chromium.org, Dec 3

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48dcf08391633a6251ce68ab41428a3001beaac2

commit 48dcf08391633a6251ce68ab41428a3001beaac2
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Mon Dec 03 21:41:24 2018

[Settings WebUI] Introduce Autofill Section

This change introduces a new Autofill section into the Chrome settings
UI. This section contains "Passwords", "Payment Methods" and "Addresses
and more", which prior to this change were part of the People section.
In particular, this change:

- Renames passwords_and_forms_page to autofill_page
- Moves autofill entries from people_page.html to autofill_page.html
- Adds a chrome://settings/autofill route for the new section, renaming
  the previously existing autofill route to chrome://settings/addresses
- Removes the kAutofillHome feature flag and related conditionals
- Removes a few now obsolete strings from settings_strings.grdp

Bug: 907035,  854562 
Change-Id: I479841db651c23813ab1ac1525f712d0ff9266c2
Reviewed-on: https://chromium-review.googlesource.com/c/1348039
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612541}(cherry picked from commit 38d2033c0f32eb34cb03791579b1c2b47db36888)
Reviewed-on: https://chromium-review.googlesource.com/c/1358638
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#16}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/app/settings_strings.grdp
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/BUILD.gn
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/BUILD.gn
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/address_edit_dialog.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/address_edit_dialog.js
[add] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/autofill_browser_proxy.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/autofill_browser_proxy.js
[add] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/autofill_page.html
[add] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/autofill_page.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/autofill_section.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/autofill_section.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/credit_card_edit_dialog.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/credit_card_edit_dialog.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/password_edit_dialog.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/password_edit_dialog.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/password_list_item.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/password_list_item.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/password_manager_proxy.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/password_manager_proxy.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/passwords_export_dialog.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/passwords_export_dialog.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/passwords_section.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/passwords_section.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/passwords_shared_css.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/payments_section.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/payments_section.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/show_password_behavior.html
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/autofill_page/show_password_behavior.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/lazy_load.html
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/page_visibility.js
[delete] https://crrev.com/c0c275827fa4835660183f394ac06d0245a5480c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[delete] https://crrev.com/c0c275827fa4835660183f394ac06d0245a5480c/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/people_page/BUILD.gn
[delete] https://crrev.com/c0c275827fa4835660183f394ac06d0245a5480c/chrome/browser/resources/settings/people_page/people_browser_proxy.html
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/settings_menu/settings_menu.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/ui/views/payments/payment_request_browsertest.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/common/webui_url_constants.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/common/webui_url_constants.h
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/test/data/webui/settings/a11y/passwords_a11y_test.js
[rename] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/test/data/webui/settings/autofill_browsertest.js
[add] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/test/data/webui/settings/autofill_page_test.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/test/data/webui/settings/route_tests.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/components/password_manager/core/common/password_manager_features.h
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter
[modify] https://crrev.com/48dcf08391633a6251ce68ab41428a3001beaac2/testing/buildbot/filters/webui_polymer2_browser_tests.filter
Project Member

Comment 25 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/48dcf08391633a6251ce68ab41428a3001beaac2

Commit: 48dcf08391633a6251ce68ab41428a3001beaac2
Author: jdoerrie@chromium.org
Commiter: jdoerrie@chromium.org
Date: 2018-12-03 21:41:24 +0000 UTC

[Settings WebUI] Introduce Autofill Section

This change introduces a new Autofill section into the Chrome settings
UI. This section contains "Passwords", "Payment Methods" and "Addresses
and more", which prior to this change were part of the People section.
In particular, this change:

- Renames passwords_and_forms_page to autofill_page
- Moves autofill entries from people_page.html to autofill_page.html
- Adds a chrome://settings/autofill route for the new section, renaming
  the previously existing autofill route to chrome://settings/addresses
- Removes the kAutofillHome feature flag and related conditionals
- Removes a few now obsolete strings from settings_strings.grdp

Bug: 907035,  854562 
Change-Id: I479841db651c23813ab1ac1525f712d0ff9266c2
Reviewed-on: https://chromium-review.googlesource.com/c/1348039
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612541}(cherry picked from commit 38d2033c0f32eb34cb03791579b1c2b47db36888)
Reviewed-on: https://chromium-review.googlesource.com/c/1358638
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#16}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment