New issue
Advanced search Search tips

Issue 854552 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Single digit of password is seen in saved password bubble even after erasing password .

Reported by shruti.j...@etouch.net, Jun 20 2018

Issue description

Chrome Version: 68.0.3440.33 (Official Build) Revision d62017a8f8d8d64411d2c510a5355c88b0cf9671-refs/branch-heads/3440@{#460} 32/64-bit.
OS: Windows(7,8,8.1,10), Mac OS X(10.12.6,10.13.1,10.13.6)and Linux(14.04 LTS).

Pre-Condition:Enable' Password Generation' Flag from chrome://flags

Test URL:facebook.com

Steps to reproduce:
1.Launch chrome and Navigate to above URL.
2.Click on 'New Password' so that password generation auto-populate.
3.Click on auto-populated password and delete password using 'backspace'  from keyboard.
4.Click on Key present in omnibox and observe.

Actual:Single digit of password  is seen in saved password bubble even after clearing the generated password using backspace .
Expected:No such entry should be seen in saved password bubble after clearing the generated password using backspace .

This is regression issue broken in ‘M-68’ and will providing per revision-bisect info:
Good Build:67.0.3396.0(Revision:550857)
Bad Build:68.0.3397.0(Revision:550429)

You are probably looking for a change made after 550556 (known good), but no later than 550557 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/860f4fd3c055b3c0cf66e29cd19a203c8863425a..bac8bac2098092cda46c8214787c467e11e40e49

Suspect:https://chromium.googlesource.com/chromium/src/+/bac8bac2098092cda46c8214787c467e11e40e49

@Christos Froussios:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached video.

Thank You!

 
 
Actual_Result.mp4
528 KB View Download
Expected_Result.mp4
473 KB View Download
Cc: pbomm...@chromium.org
Cc: dvadym@chromium.org kolos@chromium.org
I am able to reproduce as described, with additional symptoms
* Once the password is completely cleared, a password with a single digit is shown
* If I modify the password without clearing it completely, clicking the key icon will show no passwords. Clicking a second time will show 2 passwords.

This bug is a side-effect of setting the password_element every time we create new pending credentials. I'm still investigating to find the exact location where the password_element is expected to be empty.
Status: Fixed (was: Assigned)
I am no longer able to reproduce on trunk (M70)

Sign in to add a comment