Issue metadata
Sign in to add a comment
|
Regression: Unable to open Chrome Task Manager and 'DevTools was disconnected...' overlay gets dismissed on pressing "Shift + Esc" key from keyboard.
Reported by
dchau...@etouch.net,
Jun 20 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 68.0.3440.33 (Official Build) Revision d62017a8f8d8d64411d2c510a5355c88b0cf9671-refs/branch-heads/3440@{#460} 32/64-bit. OS: Windows(7,8,8.1,10), Linux(14.04 LTS). What steps will reproduce the problem? 1. Launch Chrome and kill the any page by typing Chrome://kill in omnibox. 2. Open DevTools so that 'DevTools was disconnected from the page' overlay appears. 3. Press "Shift + Esc" key from keyboard to open Chrome 'Task Manager' window and observe. Actual: Chrome 'Task Manager' window doesn't open and 'DevTools was disconnected from the page' overlay gets dismissed on pressing "Shift + Esc" key from keyboard. Expected: Chrome 'Task Manager' window should open and 'DevTools was disconnected from the page' overlay should not dismiss on pressing "Shift + Esc" key from keyboard. This is a regression issue, broken in M-61 series, below is manual regression range: Good build: 61.0.3133.0 (Revision: 480260) Bad build: 61.0.3134.0 (Revision: 480301) Unable to provide the bisect using has-bisect-per-revision script, hence providing the bisect using old script: Narrow bisect: You are probably looking for a change made after 480263 (known good), but no later than 480271 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/ce3f7dbfedb4040c7077644654f174b92169c3ec..59d5b2b8766a4f7eefe357f60f7af2d240c3e1d7 Suspecting: https://chromium.googlesource.com/chromium/src/+/22e08ddc30a4911bf9ec2e6b37551990d6f16a54 @chenwilliam: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. This issue is not seen on Mac(10.12.6 , 10.13.1 , 10.13.6)OS. 2. This issue is also reproducible on Stable build #67.0.3396.87, Beta build # 68.0.3440.25 and Canary build # 69.0.3466.0 3. This issue is only reproducible for first instance only. Kindly review the attached screen-cast for reference. Thank you.
,
Oct 31
Thanks for the report. Reducing priority, since users can still press Shift-Esc after the "disconnected" dialog disappears. DevTools is supposed to handle "Esc", but not "Shift+Esc". I'll take a look.
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb81f8aec78b746cef4a6fa91ebf3ab4b12ace73 commit cb81f8aec78b746cef4a6fa91ebf3ab4b12ace73 Author: Erik Luo <luoe@chromium.org> Date: Tue Dec 11 02:37:53 2018 DevTools: do not hide dialog on Esc with modifiers Users expect pressing 'Escape' to hide dialogs in DevTools, except when used with another modifier, e.g. 'Shift-Esc'. Bug: 854548 Change-Id: I33f5052c44c70cacd2a4197161a502ac9c69fcee Reviewed-on: https://chromium-review.googlesource.com/c/1366485 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615394} [modify] https://crrev.com/cb81f8aec78b746cef4a6fa91ebf3ab4b12ace73/third_party/blink/renderer/devtools/front_end/ui/Dialog.js
,
Dec 11
,
Dec 12
Update: Rechecked this issue on Windows(7,8,8.1,10) and Linux(14.04) machines using latest Canary #73.0.3638.0 and issue is fixed. Hence adding TE-Verified labels. Please refer the attached screen-cast for reference. Thank you..! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dgozman@chromium.org
, Oct 31