Issue metadata
Sign in to add a comment
|
4.4%-50% regression in webrtc_perf_tests at 23648:23648 |
||||||||||||||||||||
Issue descriptionChromium roll increased memory consumption in webrtc_perf_tests: https://webrtc.googlesource.com/src/+/024eeff4215d39a043ad9e890907861e6d216ef8
,
Jun 20 2018
Patrik, this roll couldn't have change the tests order or some other testing configuration, right?
,
Jun 20 2018
I don't think it would change the test order, but tests should not make assumptions about in which order other tests execute anyway. Chromium rolls can and will change the build system and test execution environment however. WebRTC production code doesn't directly depend on any chromium code, so the only possibility of this being a real issue is that the build system changed in such a way that the production code is using more memory, or if one of our third party libs use more memory (such as libyuv or libvpx). Let's look at third parties that were rolled in this CL. BoringSSL: - I guess this one could be suspect: https://boringssl.googlesource.com/boringssl.git/+/b570fd9fd6b47c31ae0014f1cdc748f7a4634d81 - No other ideas Libvpx: - No obvious culprits, not sure what to look for Libyuv: - Maybe https://chromium.googlesource.com/libyuv/libyuv.git/+/083aa718b9297326eb969fc6c2b3607080714bc8%5E%21/#F2? Finally, it could be a win build system or test harness change. The former sounds unlikely; I can't find an obvious culprit in https://chromium.googlesource.com/chromium/src/build/+log/169887d089..f29a733cc2. I can't find anything on Windows or memory in the //testing changelog either: https://chromium.googlesource.com/chromium/src/testing/+log/5951b2830b..04314205f8 I would say this is highly inconclusive, most probably a WontFix unless someone makes a genius analysis. If you want to dig deeper into the libvpx or other 3pp changes, go for it.
,
Aug 20
As of https://webrtc.googlesource.com/src/+/b4dfdf574d31cf79b771199836584f1d1a4357a0 memory consumption went back. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jun 20 2018