New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854497 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser crash is seen on opening links in new tab when chrome://discards tab is opened

Project Member Reported by susan.boorgula@chromium.org, Jun 20 2018

Issue description

Chrome Version: 69.0.3465.0
OS: Windows 10, Ubuntu 14.04

What steps will reproduce the problem?
(1)Launch Chrome and navigate to chrome://discards.
(2)On a new tab search for google or wikipedia and mouse middle click to open links in new tabs.
(3)Browser is crashed.

Expected result : Browser crash should not be seen
Actual Result : Browser crash

Crash IDs: d188e0af4714609c , f86f4c118234b7ca.

Will update the bisect info soon.
Adding ReleaseBlock-Stable as this is a recent regression. Please feel free to remove if it is not applicable.

Note: Unable to provide Mac OS behavior due to blocking issue 854114. Will update the behavior once latest build is available.

Thanks..


 
Labels: -ReleaseBlock-Stable RegressedIn-69 ReleaseBlock-Beta Target-69 FoundIn-69 OS-Mac
Owner: chrisha@chromium.org
Status: Assigned (was: Untriaged)
// Adding to the above comment.

Able to reproduce the issue on Mac OS 10.13.5 on the latest Canary 69.0.3466.0.

Bisect Information:
===================
Good Build: 69.0.3464.0
Bad Build : 69.0.3465.0

By running the per-revision bisect script, the below changelog URL was returned:
https://chromium-review.googlesource.com/1076809
But this seems to be irrelevant to the issue.

Hence providing manual Changelog URL from omahaproxy:

https://chromium.googlesource.com/chromium/src/+log/69.0.3464.0..69.0.3465.0?pretty=fuller&n=10000

From the above Changelog, suspecting the below change:
Reviewed-on: https://chromium-review.googlesource.com/1100086

chrisha@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Removing 'ReleaseBlock-Stable' label and adding 'ReleaseBlock-Beta' as this issue is on the latest Canary. Please feel free to remove if it is not applicable.

Thanks
Labels: hasbisect HasTestcase

Comment 3 by fdoray@chromium.org, Jun 22 2018

Components: -Internals Internals>ResourceCoordinator
Owner: fdoray@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb3988a5198d953ef6ac5e7ba6c8b6a88c984a6a

commit bb3988a5198d953ef6ac5e7ba6c8b6a88c984a6a
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Jun 22 18:24:39 2018

RC: Fix invalid access when getting site engagement score in chrome://discards.

There was an invalid access when the site engagement score of a
WebContents that was never navigated was obtained in chrome://discards.
With this CL, we return 0 as the engagement score of never-navigated
WebContents, instead of doing an invalid access.

Creating a new tab or opening a link in a new tab are actions that
create a WebContents a briefly keep it in a non-navigated state.

Bug:  854497 
Change-Id: I204509b7c41445ac4b524f9a652f006189e4fcd9
Reviewed-on: https://chromium-review.googlesource.com/1111908
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569700}
[modify] https://crrev.com/bb3988a5198d953ef6ac5e7ba6c8b6a88c984a6a/chrome/browser/ui/webui/discards/discards_ui.cc

Labels: TE-Verified-M69 TE-Verified-69.0.3472.0
Able to reproduce this issue on Windows 10, Mac OS 10.13.5 and Ubuntu 14.04 on the build without fix 69.0.3465.0 and the issue is fixed on the latest Canary 69.0.3472.0.
Cannot observe any browser crash after following the steps mentioned in the original comment.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
854497-M69.mp4
3.2 MB View Download

Comment 6 by fdoray@chromium.org, Jun 26 2018

Status: Fixed (was: Started)

Sign in to add a comment