New issue
Advanced search Search tips

Issue 854494 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 857295



Sign in to add a comment

Allow user to set the shader disk cache

Project Member Reported by gyuyoung...@chromium.org, Jun 20 2018

Issue description

Although there have been the thresholds of cache usage limitations for the Android in /gpu/config/gpu_preferences.h, it would be good if we can give embedders the power to set the cache size for the ShaderDiskCache. Because there are many various embedded devices which have different sizes of disk.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b62f9ecf53aa8b0f56c7219489e8988b470d3111

commit b62f9ecf53aa8b0f56c7219489e8988b470d3111
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Thu Jun 21 11:54:45 2018

Pass the cache size in the command line to the ShaderDiskCache::CacheSizeBytes

Although there have been the thresholds of cache usage limitations for the Android
in /gpu/config/gpu_preferences.h, it would be good if we can give embedders the power
to set the cache size for the ShaderDiskCache. Because there are many various embedded
devices which have different sizes of disk.

Bug:  854494 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie1ecb903a79e52ee79503df30fe1ae15b95739ea
Reviewed-on: https://chromium-review.googlesource.com/1107517
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569221}
[modify] https://crrev.com/b62f9ecf53aa8b0f56c7219489e8988b470d3111/gpu/config/gpu_switches.cc
[modify] https://crrev.com/b62f9ecf53aa8b0f56c7219489e8988b470d3111/gpu/config/gpu_switches.h
[modify] https://crrev.com/b62f9ecf53aa8b0f56c7219489e8988b470d3111/gpu/ipc/host/shader_disk_cache.cc

Blocking: 857295
Status: Fixed (was: Untriaged)

Sign in to add a comment