context: issue 854218 , comment 4 make service.search function async (ndb tasklet). This will be quite a refactoring.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b5e5c162721e291db025d2c4fadd669cc9b8c178 commit b5e5c162721e291db025d2c4fadd669cc9b8c178 Author: Nodir Turakulov <nodir@google.com> Date: Wed Jun 20 21:25:43 2018 [buildbucket] Make acl.get_acessible_buckets async Bug: 854484 Change-Id: Ic4bf47d69036a905e902f3ab8e8fe106bd0aa4c3 Reviewed-on: https://chromium-review.googlesource.com/1107480 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/b5e5c162721e291db025d2c4fadd669cc9b8c178/appengine/cr-buildbucket/acl.py [modify] https://crrev.com/b5e5c162721e291db025d2c4fadd669cc9b8c178/appengine/cr-buildbucket/v2/test/api_test.py [modify] https://crrev.com/b5e5c162721e291db025d2c4fadd669cc9b8c178/appengine/cr-buildbucket/service.py [modify] https://crrev.com/b5e5c162721e291db025d2c4fadd669cc9b8c178/appengine/cr-buildbucket/swarming/swarmbucket_api.py [modify] https://crrev.com/b5e5c162721e291db025d2c4fadd669cc9b8c178/appengine/cr-buildbucket/test/acl_test.py [modify] https://crrev.com/b5e5c162721e291db025d2c4fadd669cc9b8c178/appengine/cr-buildbucket/test/service_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b16395c45bc3991c71ed4d8a538b636cb9cbb72c commit b16395c45bc3991c71ed4d8a538b636cb9cbb72c Author: Nodir Turakulov <nodir@google.com> Date: Wed Jun 20 21:46:00 2018 [buildbucket] Rename acl.py to user.py Delegation token minting will be moved to user.py and user.py will grow request-level cache for the current user, e.g. delegation token and a list of accessible buckets. Bug: 854484 , 854339 Change-Id: I8eade6ef8af1bea3f1771904fdf432b0b267ff1c Reviewed-on: https://chromium-review.googlesource.com/1108181 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/access/api.py [rename] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/test/user_test.py [modify] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/v2/test/api_test.py [modify] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/service.py [modify] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/swarming/swarmbucket_api.py [modify] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/api.py [modify] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py [modify] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/access/test/api_test.py [modify] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/test/service_test.py [rename] https://crrev.com/b16395c45bc3991c71ed4d8a538b636cb9cbb72c/appengine/cr-buildbucket/user.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6d32cf17e15b226a257fb4f86f2698f159ed9396 commit 6d32cf17e15b226a257fb4f86f2698f159ed9396 Author: Nodir Turakulov <nodir@google.com> Date: Wed Jun 20 22:31:01 2018 [buildbucket] Add per-request caching on accessible buckets We don't have a python lib for per-request or process caching, so roll our own, scoped down to the current identity in the current request, based on threading.Local. It caches a future. Will be used for delegation cache too. Bug: 854339 , 854484 Change-Id: I495f4ecec768c078a06f10c4e23eedcdf3ef7bd9 Reviewed-on: https://chromium-review.googlesource.com/1108387 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/6d32cf17e15b226a257fb4f86f2698f159ed9396/appengine/cr-buildbucket/swarming/test/swarmbucket_api_test.py [modify] https://crrev.com/6d32cf17e15b226a257fb4f86f2698f159ed9396/appengine/cr-buildbucket/user.py [modify] https://crrev.com/6d32cf17e15b226a257fb4f86f2698f159ed9396/appengine/cr-buildbucket/test/user_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/869f21e4cdbc2bf99b4ed2c0b51b5cbecda26ece commit 869f21e4cdbc2bf99b4ed2c0b51b5cbecda26ece Author: Nodir Turakulov <nodir@google.com> Date: Wed Jun 20 23:46:01 2018 [buildbucket] Move parse_identity from service.py to user.py Bug: 854484 , 840853 Change-Id: I42a64c6d163bec3bce86ec0d4dc829fda0b5d261 Reviewed-on: https://chromium-review.googlesource.com/1108508 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/869f21e4cdbc2bf99b4ed2c0b51b5cbecda26ece/appengine/cr-buildbucket/service.py [modify] https://crrev.com/869f21e4cdbc2bf99b4ed2c0b51b5cbecda26ece/appengine/cr-buildbucket/user.py [modify] https://crrev.com/869f21e4cdbc2bf99b4ed2c0b51b5cbecda26ece/appengine/cr-buildbucket/test/user_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8c3bc760c43930c867638648281adf8cf22ceb43 commit 8c3bc760c43930c867638648281adf8cf22ceb43 Author: Nodir Turakulov <nodir@google.com> Date: Thu Jun 21 00:49:01 2018 [buildbucket] Add search.py Move search-related code from monolithic service.py and model.py to search.py, including two search implementations and TagIndex data models. No functional changes. Bug: 854484 , 840853 Change-Id: If83db1b82c82ed9d4fa84d1d67da42974f579105 Reviewed-on: https://chromium-review.googlesource.com/1108566 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/handlers.py [add] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/search.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/handlers_test.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/service_test.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/v2/api.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/api_test.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/v2/test/api_test.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/service.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/model_test.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/api.py [add] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/test/search_test.py [modify] https://crrev.com/8c3bc760c43930c867638648281adf8cf22ceb43/appengine/cr-buildbucket/model.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/65dad2148094ac50e2c3be7bc519b9f608908366 commit 65dad2148094ac50e2c3be7bc519b9f608908366 Author: Nodir Turakulov <nodir@google.com> Date: Thu Jun 21 16:01:57 2018 [buildbucket] Make search.search async Taskletize search.search function. Bug: 854484 Change-Id: Ia6aea0558033c83a0659e3fbe9711ba27ad11678 Reviewed-on: https://chromium-review.googlesource.com/1109409 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/65dad2148094ac50e2c3be7bc519b9f608908366/appengine/cr-buildbucket/test/search_test.py [modify] https://crrev.com/65dad2148094ac50e2c3be7bc519b9f608908366/appengine/cr-buildbucket/user.py [modify] https://crrev.com/65dad2148094ac50e2c3be7bc519b9f608908366/appengine/cr-buildbucket/v2/api.py [modify] https://crrev.com/65dad2148094ac50e2c3be7bc519b9f608908366/appengine/cr-buildbucket/test/api_test.py [modify] https://crrev.com/65dad2148094ac50e2c3be7bc519b9f608908366/appengine/cr-buildbucket/v2/test/api_test.py [modify] https://crrev.com/65dad2148094ac50e2c3be7bc519b9f608908366/appengine/cr-buildbucket/service.py [modify] https://crrev.com/65dad2148094ac50e2c3be7bc519b9f608908366/appengine/cr-buildbucket/api.py [modify] https://crrev.com/65dad2148094ac50e2c3be7bc519b9f608908366/appengine/cr-buildbucket/search.py
Comment 1 by bugdroid1@chromium.org
, Jun 20 2018