New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-01
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 854474: Implement console.timeLog

Reported by domfarolino@gmail.com, Jun 20 2018 Project Member

Issue description

Comment 2 by kozy@chromium.org, Sep 27

Owner: kozy@chromium.org
Status: Assigned (was: Available)
https://chromium-review.googlesource.com/c/v8/v8/+/1247641

Comment 3 by bugdroid1@chromium.org, Sep 28

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7b32eb8c7b6b8645717248c6bf3287bd46b67cab

commit 7b32eb8c7b6b8645717248c6bf3287bd46b67cab
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Sep 28 17:34:08 2018

inspector: implement console.timeLog

New method was added to console spec [1].
This CL implements it.

[1] https://console.spec.whatwg.org/#timelog

R=dgozman@chromium.org,yangguo@chromium.org

Bug:  chromium:854474 
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie5f249795979bb886cf824ae9f950c5ef78ce04d
Reviewed-on: https://chromium-review.googlesource.com/1247641
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56294}
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/src/bootstrapper.cc
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/src/builtins/builtins-console.cc
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/src/builtins/builtins-definitions.h
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/src/debug/interface-types.h
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/src/inspector/v8-console-message.cc
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/src/inspector/v8-console-message.h
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/src/inspector/v8-console.cc
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/src/inspector/v8-console.h
[modify] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/test/inspector/runtime/console-context-expected.txt
[add] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/test/inspector/runtime/console-time-log-expected.txt
[add] https://crrev.com/7b32eb8c7b6b8645717248c6bf3287bd46b67cab/test/inspector/runtime/console-time-log.js

Comment 5 by kozy@chromium.org, Sep 28

NextAction: 2018-10-01
Last step: reenable tests around Monday.

Comment 6 by monor...@bugs.chromium.org, Oct 1

The NextAction date has arrived: 2018-10-01

Comment 7 by bugdroid1@chromium.org, Oct 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06fe5390110c271eaf6232a3a17559736c7d297

commit b06fe5390110c271eaf6232a3a17559736c7d297
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Oct 02 18:44:09 2018

DevTools: reenable tests

TBR=dgozman@chromium.org

Bug:  chromium:854474 
Change-Id: Iae615d06e1c6fe207a889f989df5a396aed72073
Reviewed-on: https://chromium-review.googlesource.com/c/1255574
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595926}
[modify] https://crrev.com/b06fe5390110c271eaf6232a3a17559736c7d297/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by kozy@chromium.org, Oct 2

Cc: -kozyatinskiy@chromium.org vamshi.kommuri@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment