New issue
Advanced search Search tips

Issue 854473 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[WPT] New failures introduced in external/wpt/infrastructure by import https://crrev.com/c/1107249

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Jun 20 2018

Issue description

WPT import https://crrev.com/c/1107249 introduced new failures in external/wpt/infrastructure:

List of new failures:
external/wpt/infrastructure/server/order-of-metas.any.html new failing tests: https://crrev.com/c/1107249/4/third_party/WebKit/LayoutTests/external/wpt/infrastructure/server/order-of-metas.any-expected.txt
external/wpt/infrastructure/server/order-of-metas.window.html new failing tests: https://crrev.com/c/1107249/4/third_party/WebKit/LayoutTests/external/wpt/infrastructure/server/order-of-metas.window-expected.txt
external/wpt/infrastructure/server/order-of-metas.any.worker.html [ Timeout ]
external/wpt/infrastructure/server/order-of-metas.any.sharedworker.html [ Timeout ]

This import contains upstream changes from 9a418a0c09fd40b099e835d1a6e16e352ffe9aad to 637eee0d9bd1a74803a1ba51e3391edc7e94d45d:
Do not throw when we don't have a style, but just return an empty style.: https://github.com/web-platform-tests/wpt/commit/637eee0d9bd1a74803a1ba51e3391edc7e94d45d
[performance-timeline] Reformat tests (#11495): https://github.com/web-platform-tests/wpt/commit/50f1ceebcf83482f7ce4edd5a33f25cd27ee6e38
ServiceWorker: Use [SecureContext] instead of manual check: https://github.com/web-platform-tests/wpt/commit/dc2cc220fecd1ee280471c6de4a50d279285b9b6
Move font-feature-values to Fonts 4 (#11563): https://github.com/web-platform-tests/wpt/commit/ea89f99213d96a51ced42f063b30dcc859ff18f8
Clean up enumerateDevices IDL test (#11577): https://github.com/web-platform-tests/wpt/commit/a0ae4381449ef33d52a1f8b4a608666bf4fba0c9
[wptserve] Put `// META:` scripts after testharness.js (#11344): https://github.com/web-platform-tests/wpt/commit/bde52314cb009dce1a83cb01eae3715ae5f7a1c9 [affecting this directory]
Auto-update the mediacapture-fromelement IDL file (#11575): https://github.com/web-platform-tests/wpt/commit/0b687e0244aebdaf4b10d567725f6ee8cac89107
Auto-update the mediacapture-image IDL file (#11576): https://github.com/web-platform-tests/wpt/commit/432a9ab4f172bc63111f5fba6a7e2dc444d695f3
Update the mediacapture-record IDL file (#9907): https://github.com/web-platform-tests/wpt/commit/612c0c09cf8216e73c1afdaec95835a5ca280af8
Merge pull request #10610 from web-platform-tests/zcorpan/webrtc-stats-owners: https://github.com/web-platform-tests/wpt/commit/dd7af43f8d6ee49b8eb960438629e9986e3eea07
Merge pull request #10577 from dontcallmedom/webrtc-stats: https://github.com/web-platform-tests/wpt/commit/4bfcec713eb4b300c00999f99b74afdf1fcc821f
Fix py3 syntax/import errors on pywebsocket (#11518): https://github.com/web-platform-tests/wpt/commit/0c43d267a6512152298e0016c2a02480f18b2347
revert to WebSocketServer: https://github.com/web-platform-tests/wpt/commit/b8799623ceeefbefbc9332337e5cb5563ba82a6c
Propagate directionality to the shadow tree.: https://github.com/web-platform-tests/wpt/commit/393e00bbe327e824fbe874f22a9a345252710e6c
Change to META.yml: https://github.com/web-platform-tests/wpt/commit/60cb8003249ce86900442ed5abc69ac8bff648a6
Remove alvestrand, add henbos: https://github.com/web-platform-tests/wpt/commit/155a927160f5808a766b90222eaaf3fdc07115dc
[webrtc-stats] add OWNERS: https://github.com/web-platform-tests/wpt/commit/a6da0ee4596cc6918504778c770703c178eae731
fix configparser error: https://github.com/web-platform-tests/wpt/commit/c1f6ae49064d0841517e670c8d223e317e2a1a04
fix py3 syntax/import errors on pywebsocket: https://github.com/web-platform-tests/wpt/commit/58a9a81a25297cd4e38f5b9126f9ec1cdc02f1ae
Strip webrtc/ prefix: https://github.com/web-platform-tests/wpt/commit/1b58a73c1b1922c52df3a5a4e9c2d6a9e2ad4760
See directory for WebRTC Statistic spec: https://github.com/web-platform-tests/wpt/commit/fb09dc229624abb62611e2afd0ae0d82d22714bf

 
Cc: -robertma@chromium.org
Labels: Pri-2 Type-Bug
Owner: robertma@chromium.org
Status: Assigned (was: Untriaged)
Needs to roll in https://github.com/web-platform-tests/wpt/pull/11344 (wptserve)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/766eaa49cdf43e9b08861c885409ea0b19133681

commit 766eaa49cdf43e9b08861c885409ea0b19133681
Author: Robert Ma <robertma@chromium.org>
Date: Thu Jun 21 09:53:35 2018

Roll in a new version of WPT tools

Mainly for https://github.com/web-platform-tests/wpt/pull/11344

Rebaselined some affected infra tests.
(Note: a SAB test in html/infrastructure is now failing instead of
timing out because of the wptserve change. The failure is expected
because SAB is currently disabled, so we change the expectation
accordingly.)

Bug:  854473 
Change-Id: I0f3218328992141033a593be0882c436ec7ff7a6
Reviewed-on: https://chromium-review.googlesource.com/1108744
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569200}
[modify] https://crrev.com/766eaa49cdf43e9b08861c885409ea0b19133681/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/c2abf7305cff4239716a76162319b772312b20f5/third_party/WebKit/LayoutTests/external/wpt/infrastructure/server/order-of-metas.any-expected.txt
[delete] https://crrev.com/c2abf7305cff4239716a76162319b772312b20f5/third_party/WebKit/LayoutTests/external/wpt/infrastructure/server/order-of-metas.window-expected.txt
[modify] https://crrev.com/766eaa49cdf43e9b08861c885409ea0b19133681/third_party/blink/tools/blinkpy/third_party/README.chromium
[modify] https://crrev.com/766eaa49cdf43e9b08861c885409ea0b19133681/third_party/blink/tools/blinkpy/third_party/wpt/checkout.sh
[modify] https://crrev.com/766eaa49cdf43e9b08861c885409ea0b19133681/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/766eaa49cdf43e9b08861c885409ea0b19133681/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/browser.py
[modify] https://crrev.com/766eaa49cdf43e9b08861c885409ea0b19133681/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/wpt/run.py

Comment 3 by foolip@chromium.org, Jun 21 2018

Status: Fixed (was: Assigned)

Sign in to add a comment