Issue metadata
Sign in to add a comment
|
Layout test images/feature-policy-max-downscaling-image.html flaky |
||||||||||||||||||||||
Issue descriptionSeen flaky in these virtual test suites: virtual/exotic-color-space/images/feature-policy-max-downscaling-image.html virtual/gpu-rasterization/images/feature-policy-max-downscaling-image.html The test seems flaky on the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/gpu-rasterization/images/feature-policy-max-downscaling-image.html but somewhat hard to see on the win7_chromium_rel_ng tryserver. A couple of affected runs: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/19842 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/19826 Seen first on this unrelated tryjob: https://chromium-review.googlesource.com/1107275 Not sure what the right components are. vmpstr@, could you please help triage or redirect this?
,
Jun 21 2018
Any progress on this? I hit this in two consecutive tryjob runs today: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/21000 and https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/21046
,
Jun 21 2018
This is affecting the commit queue. The test should be disabled temporarily if it can't be fixed promptly.
,
Jun 21 2018
Also images/feature-policy-max-downscaling-image.html https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/21765
,
Jun 21 2018
I uploaded a fix >1d ago [1], but reviewer response was slower than anticipated. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1107805
,
Jun 21 2018
-Sheriff-Chromium since the CL is now in the CQ
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d55393ffee0e5612c8fcc3d314c57044f76cbdd1 commit d55393ffee0e5612c8fcc3d314c57044f76cbdd1 Author: Fredrik Söderquist <fs@opera.com> Date: Fri Jun 22 00:09:18 2018 Update/recompute the is-downscaled flag when image loading finishes If the <img> is layouted before the referenced image finishes loading (and has dimensions available) and also has specified width and height, then the |LayoutImage::is_downscaled_image_| will not be set correctly. Also update said flag in LayoutImage::ImageNotifyFinished. Bug: 854464 Change-Id: Iee9ad62dff436a0ef4d4a390902309159acb7cb7 Reviewed-on: https://chromium-review.googlesource.com/1107805 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569462} [add] https://crrev.com/d55393ffee0e5612c8fcc3d314c57044f76cbdd1/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-forced-layout-expected.html [add] https://crrev.com/d55393ffee0e5612c8fcc3d314c57044f76cbdd1/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image-forced-layout.html [add] https://crrev.com/d55393ffee0e5612c8fcc3d314c57044f76cbdd1/third_party/WebKit/LayoutTests/images/resources/frame-with-max-downscaling-image-test-images-forced-layout.html [modify] https://crrev.com/d55393ffee0e5612c8fcc3d314c57044f76cbdd1/third_party/blink/renderer/core/layout/layout_image.cc
,
Jun 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by f...@opera.com
, Jun 20 2018Owner: f...@opera.com
Status: Assigned (was: Untriaged)