New issue
Advanced search Search tips

Issue 854442 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
weiliangc@chromium.org
jamescook@chromium.org
sky@chromium.org
jmad...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

GPU FYI Win compile failing on 2 builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 20 2018

Comment 1 by weiliangc@chromium.org, Jun 20 2018

Cc: sky@chromium.org jmad...@chromium.org
Components: Internals>GPU>Testing
Labels: Hotlist-PixelWrangler
Compile error:
[40824/45748] LINK task_viewer.service.exe task_viewer.service.exe.pdb
FAILED: task_viewer.service.exe task_viewer.service.exe.pdb 
C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./task_viewer.service.exe /PDB:./task_viewer.service.exe.pdb @./task_viewer.service.exe.rsp
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ
>>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ)
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ
>>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ)
[40825/45748] LINK window_type_launcher.service.exe window_type_launcher.service.exe.pdb
FAILED: window_type_launcher.service.exe window_type_launcher.service.exe.pdb 
C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./window_type_launcher.service.exe /PDB:./window_type_launcher.service.exe.pdb @./window_type_launcher.service.exe.rsp
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ
>>> referenced by obj/mash/example/window_type_launcher/window_type_launcher/window_type_launcher.obj:(?OnStart@WindowTypeLauncher@@EEAAXXZ)
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ
>>> referenced by obj/mash/example/window_type_launcher/window_type_launcher/window_type_launcher.obj:(?OnStart@WindowTypeLauncher@@EEAAXXZ)
[40826/45748] LINK simple_wm.service.exe simple_wm.service.exe.pdb
FAILED: simple_wm.service.exe simple_wm.service.exe.pdb 
C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./simple_wm.service.exe /PDB:./simple_wm.service.exe.pdb @./simple_wm.service.exe.rsp
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ
>>> referenced by obj/mash/simple_wm/lib/simple_wm.obj:(?OnStart@SimpleWM@simple_wm@@EEAAXXZ)
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ
>>> referenced by obj/mash/simple_wm/lib/simple_wm.obj:(?OnStart@SimpleWM@simple_wm@@EEAAXXZ)
[40827/45748] LINK(DLL) policy_component.dll policy_component.dll.lib policy_component.dll.pdb


Suspect:
https://chromium-review.googlesource.com/c/chromium/src/+/1106431

Going to revert.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e959c2d7418e28eaf18df776bf039a16cfd8a8dd

commit e959c2d7418e28eaf18df776bf039a16cfd8a8dd
Author: weiliangc <weiliangc@chromium.org>
Date: Wed Jun 20 01:16:21 2018

Revert "Add InitParams for views::AuraInit"

This reverts commit dfd53f11533c7d0861541e78e982e89f2dd33043.

Reason for revert: GPU FYI Windows bots compile failure
 crbug.com/854442 

Compile error:
[40824/45748] LINK task_viewer.service.exe task_viewer.service.exe.pdb
FAILED: task_viewer.service.exe task_viewer.service.exe.pdb 
C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./task_viewer.service.exe /PDB:./task_viewer.service.exe.pdb @./task_viewer.service.exe.rsp
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ
>>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ)
C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ
>>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ)

Original change's description:
> Add InitParams for views::AuraInit
> 
> It's up to 7 parameters and I'm about to add an 8th.
> 
> Bug:  851578 
> Test: existing tests
> Change-Id: I5dbfb98c90861a334ef9046cec4d69fb756879a1
> Reviewed-on: https://chromium-review.googlesource.com/1106431
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568594}

TBR=jamescook@chromium.org,sky@chromium.org

Change-Id: Iea7d59178394a95cbc6f419cd7079d00d66a8ac6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  851578 ,  854442 
Reviewed-on: https://chromium-review.googlesource.com/1107139
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568678}
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/ash/components/autoclick/autoclick_application.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/ash/components/quick_launch/quick_launch_application.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/ash/components/shortcut_viewer/shortcut_viewer_application.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/ash/components/tap_visualizer/tap_visualizer_app.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/ash/window_manager_service.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/mash/catalog_viewer/catalog_viewer.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/mash/example/views_examples/views_examples.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/mash/task_viewer/task_viewer.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/ui/views/mus/aura_init.cc
[modify] https://crrev.com/e959c2d7418e28eaf18df776bf039a16cfd8a8dd/ui/views/mus/aura_init.h

Comment 3 by weiliangc@chromium.org, Jun 20 2018

Status: Fixed (was: Available)
Latest build passed.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc1b03375d01bfd52272e49e72694c00b3f6d16f

commit fc1b03375d01bfd52272e49e72694c00b3f6d16f
Author: James Cook <jamescook@chromium.org>
Date: Wed Jun 20 16:18:27 2018

Reland "Add InitParams for views::AuraInit"

This reverts commit e959c2d7418e28eaf18df776bf039a16cfd8a8dd.

Fixed by adding EXPORT macro on the new struct.

Original change's description:
> Revert "Add InitParams for views::AuraInit"
>
> This reverts commit dfd53f11533c7d0861541e78e982e89f2dd33043.
>
> Reason for revert: GPU FYI Windows bots compile failure
>  crbug.com/854442 
>
> Compile error:
> [40824/45748] LINK task_viewer.service.exe task_viewer.service.exe.pdb
> FAILED: task_viewer.service.exe task_viewer.service.exe.pdb
> C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./task_viewer.service.exe /PDB:./task_viewer.service.exe.pdb @./task_viewer.service.exe.rsp
> C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ
> >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ)
> C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ
> >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ)
>
> Original change's description:
> > Add InitParams for views::AuraInit
> >
> > It's up to 7 parameters and I'm about to add an 8th.
> >
> > Bug:  851578 
> > Test: existing tests
> > Change-Id: I5dbfb98c90861a334ef9046cec4d69fb756879a1
> > Reviewed-on: https://chromium-review.googlesource.com/1106431
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568594}
>
> TBR=jamescook@chromium.org,sky@chromium.org
>
> Change-Id: Iea7d59178394a95cbc6f419cd7079d00d66a8ac6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  851578 ,  854442 
> Reviewed-on: https://chromium-review.googlesource.com/1107139
> Reviewed-by: weiliangc <weiliangc@chromium.org>
> Commit-Queue: weiliangc <weiliangc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568678}

TBR=jamescook@chromium.org,sky@chromium.org,weiliangc@chromium.org

Change-Id: Id0a3e75d0e02c87165375ecc345553041ecc4252
Bug:  851578 ,  854442 
Reviewed-on: https://chromium-review.googlesource.com/1107997
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568862}
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/ash/components/autoclick/autoclick_application.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/ash/components/quick_launch/quick_launch_application.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/ash/components/shortcut_viewer/shortcut_viewer_application.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/ash/components/tap_visualizer/tap_visualizer_app.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/ash/window_manager_service.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/mash/catalog_viewer/catalog_viewer.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/mash/example/views_examples/views_examples.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/mash/task_viewer/task_viewer.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/ui/views/mus/aura_init.cc
[modify] https://crrev.com/fc1b03375d01bfd52272e49e72694c00b3f6d16f/ui/views/mus/aura_init.h
►

Sign in to add a comment