New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854437 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Compat



Sign in to add a comment

llvmpipe accidentally blacklisted because it dropped a word from the renderer string

Reported by nik...@benaco.com, Jun 20 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/66.0.3359.181 Chrome/66.0.3359.181 Safari/537.36

Example URL:
chrome://gpu

Steps to reproduce the problem:
1. Run against llvmpipe 0.5
2. chrome://gpu shows a problem with GPU not working due to "VMware software renderer on older Mesa"

What is the expected behavior?
GPU works.

What went wrong?
https://cs.chromium.org/chromium/src/gpu/config/software_rendering_list.json?l=413&rcl=3fab2ea25adb3374c3fc4f040df147f8541cf944

Chromium has a check "Disable VMware software renderer on older Mesa" that should disable the software renderer on llvmpipe < 9.2.1.

That check is implemented by saying "all llvmpipe >= 9.2.1 are allowed".

It matches against

    "gl_renderer": ".*Gallium.*llvmpipe.*"

so far that works, because the renderer string (e.g. of osmesa) looked like this:

    Gallium 0.4 on llvmpipe (LLVM 4.0, 256 bits)

But in version 0.5, it looks like this instead:

    llvmpipe (LLVM 5.0, 256 bits)

Note how they have dropped the word "Gallium".

That is why Chromium's regex no longer matches successfully, and the driver is accidentally not allowed.

The fix is to switch the regex to ".*llvmpipe.*" instead.

Note there are 3 occurrences of this regex in that file.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 66.0.3359.181  Channel: n/a
OS Version: 
Flash Version:
 

Comment 1 by nik...@benaco.com, Jun 20 2018

I have compiled a version with the fix I proposed (all occurrences of the old regex replaced by the new one) and it seems to work fine for me.
Labels: Needs-Milestone
Cc: kbr@chromium.org sindhu.chelamcherla@chromium.org piman@chromium.org
Labels: Triaged-ET
cc'ing owners kbr@ and piman@ from owners list of code search https://cs.chromium.org/chromium/src/gpu/config/software_rendering_list.json?l=413&rcl=3fab2ea25adb3374c3fc4f040df147f8541cf944 given in comment#0 for further inputs on this.

Thanks!
Components: Internals>GPU

Comment 6 by kbr@chromium.org, Jun 20 2018

Components: -Internals>GPU Internals>GPU>Internals
Owner: zmo@chromium.org
Status: Assigned (was: Unconfirmed)
Replied on the CL. Please send it out for official review. Thanks.

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c04e8db10a769ede797f5ba48c38421a2fd0c2

commit d8c04e8db10a769ede797f5ba48c38421a2fd0c2
Author: Niklas Hambüchen <mail@nh2.me>
Date: Fri Jun 22 20:41:18 2018

gpu: Fix llvmpipe render string regex for llvmpipe >= 0.5

Before 0.5, render strings looked like this:

    Gallium 0.4 on llvmpipe (LLVM 4.0, 256 bits)

now they look like this:

    llvmpipe (LLVM 5.0, 256 bits)

Change the regex accordingly to avoid accidentally not matching
the llvmpipe renderer string.

Bug:  854437 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I14a7a7631880b2dcfcd3af5eeb6c01d5be32edb6
Reviewed-on: https://chromium-review.googlesource.com/1108216
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569747}
[modify] https://crrev.com/d8c04e8db10a769ede797f5ba48c38421a2fd0c2/AUTHORS
[modify] https://crrev.com/d8c04e8db10a769ede797f5ba48c38421a2fd0c2/gpu/config/software_rendering_list.json

Comment 8 by kbr@chromium.org, Jun 23 2018

Status: Fixed (was: Assigned)
Thanks for this contribution!

Closing as Fixed. Please reopen if that wasn't correct.

Sign in to add a comment