New issue
Advanced search Search tips

Issue 854426 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

Logging system for dynamic_suite v2

Project Member Reported by xixuan@chromium.org, Jun 20 2018

Issue description

This bug is for tracking logging in dynamic_suite v2 in skylab.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/67c1181da5c94770a625c0f754aa3731961f48bb

commit 67c1181da5c94770a625c0f754aa3731961f48bb
Author: Xixuan Wu <xixuan@chromium.org>
Date: Fri Jun 29 16:31:55 2018

autotest: Don't log pending provision tasks in buildbot.

Provision child tasks (dummy_Pass) could still run after provision suite
is finished. Don't log them if provision suite succeeds.

BUG= chromium:854426 
TEST=Ran it on swarming suite server.

Change-Id: I59e2ba89fd3e9adf7e1a9ecafd874858fc61dcde
Reviewed-on: https://chromium-review.googlesource.com/1107252
Tested-by: Xixuan Wu <xixuan@chromium.org>
Trybot-Ready: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/67c1181da5c94770a625c0f754aa3731961f48bb/venv/skylab_suite/suite_tracking.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ff19abe749d6d54b69c20be04a4a62790f2674a7

commit ff19abe749d6d54b69c20be04a4a62790f2674a7
Author: Xixuan Wu <xixuan@chromium.org>
Date: Fri Jun 29 16:32:18 2018

autotet: Add dut_name to test_specs, so that logging could use it.

BUG= chromium:854426 
TEST=Ran "bin/run_suite_skylab --pool=suites --board=nyan_blaze
--suite_name=provision --build=nyan_blaze-release/R69-10763.0.0
--priority 10 --timeout_mins 30 --test_retry --max_retries 5
--suite_args "{u'num_required': 1}"" locally.

Change-Id: Iac51a0d27ad4a42434675ddf35369f71996af0e8
Reviewed-on: https://chromium-review.googlesource.com/1108392
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Trybot-Ready: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/ff19abe749d6d54b69c20be04a4a62790f2674a7/venv/skylab_suite/swarming_lib.py
[modify] https://crrev.com/ff19abe749d6d54b69c20be04a4a62790f2674a7/venv/skylab_suite/suite_tracking.py
[modify] https://crrev.com/ff19abe749d6d54b69c20be04a4a62790f2674a7/venv/skylab_suite/cros_suite.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/699706d74ecdd0356dce983fb8bd6f72e59d6dfd

commit 699706d74ecdd0356dce983fb8bd6f72e59d6dfd
Author: Xixuan Wu <xixuan@chromium.org>
Date: Wed Jul 11 19:13:03 2018

HWTestSkylab: Add luci tag for skylab suite jobs.

BUG= chromium:854426 
TEST=Ran tryjob.

Change-Id: Ib7fe6d8ade6898f389fdee8bb2001a1af63a8419
Reviewed-on: https://chromium-review.googlesource.com/1123644
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/699706d74ecdd0356dce983fb8bd6f72e59d6dfd/cbuildbot/commands.py
[modify] https://crrev.com/699706d74ecdd0356dce983fb8bd6f72e59d6dfd/cbuildbot/commands_unittest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9f34f1cc9422400d35777bbeb20f3bf045d0e5a8

commit 9f34f1cc9422400d35777bbeb20f3bf045d0e5a8
Author: Xixuan Wu <xixuan@chromium.org>
Date: Fri Jul 27 18:21:32 2018

autotest: Wrap printing test logs on buildbot to single functions.

A refactor for further changes.

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: I37b63eaa07d9936001a75afd64b1664808199edc
Reviewed-on: https://chromium-review.googlesource.com/1145831
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/9f34f1cc9422400d35777bbeb20f3bf045d0e5a8/venv/skylab_suite/suite_tracking.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/61d6283f6f3d52224b9cf198c7f3b9bb08cc54bb

commit 61d6283f6f3d52224b9cf198c7f3b9bb08cc54bb
Author: Xixuan Wu <xixuan@chromium.org>
Date: Fri Aug 03 19:10:25 2018

autotest: print child task list in a separate logdog step

This CL print LogDog annotations for child tests for suites that is
created with '--create_and_return'.

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: Ie32784866140f2f2fc4af87018df88cd5f5a8af7
Reviewed-on: https://chromium-review.googlesource.com/1145894
Commit-Ready: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/61d6283f6f3d52224b9cf198c7f3b9bb08cc54bb/venv/skylab_suite/suite_tracking.py
[modify] https://crrev.com/61d6283f6f3d52224b9cf198c7f3b9bb08cc54bb/venv/skylab_suite/cros_suite.py
[modify] https://crrev.com/61d6283f6f3d52224b9cf198c7f3b9bb08cc54bb/venv/skylab_suite/cmd/run_suite_skylab.py

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8873a0ed464e365f956be58fd671377a1fc6aac1

commit 8873a0ed464e365f956be58fd671377a1fc6aac1
Author: Xixuan Wu <xixuan@chromium.org>
Date: Mon Aug 06 16:57:27 2018

autotest: Log the link of the swarming task to wait for a suite

If run_suite_skylab is kicked off with a passed-in suite_id, the process
is designed to resume the suite and wait for it to finish. In this case,
it's not enough to only log the link of the task in which the suite is
created. It's also needed to log the link of the task in which the suite
is waited for.

E.g.
https://uberchromegw.corp.google.com/i/chromeos/builders/nyan_blaze-paladin/builds/413

It only records
https://chrome-swarming.appspot.com/task?id=3ece559a9ae6b411&refresh=10&show_raw=1.

It should also records
https://chrome-swarming.appspot.com/task?id=3ece55df8a4dd310&refresh=10

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: I49360c6a4860453723849e183809f6d8c13cc358
Reviewed-on: https://chromium-review.googlesource.com/1145944
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/8873a0ed464e365f956be58fd671377a1fc6aac1/venv/skylab_suite/suite_tracking.py
[modify] https://crrev.com/8873a0ed464e365f956be58fd671377a1fc6aac1/venv/skylab_suite/cros_suite.py

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/535578af96258ab83dd158939900e2ed2b8b4ea7

commit 535578af96258ab83dd158939900e2ed2b8b4ea7
Author: Xixuan Wu <xixuan@chromium.org>
Date: Mon Aug 06 17:08:27 2018

autotest: Use swarming task id ends with '0' to show task summaries

Milo results are only generated for task summaries, that is, tasks whose
ids end in 0. This CL adjusts suite task ids to make sure they're ending
with 0.

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: If2d6f7c3414590a753be613c4172bc2d580a33f8
Reviewed-on: https://chromium-review.googlesource.com/1147200
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/535578af96258ab83dd158939900e2ed2b8b4ea7/venv/skylab_suite/suite_tracking.py

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/28e3f1575822c44794b965ac05b764a38d0a2a7c

commit 28e3f1575822c44794b965ac05b764a38d0a2a7c
Author: Xixuan Wu <xixuan@chromium.org>
Date: Mon Aug 06 17:08:53 2018

autotest: wrap test results logging into a single function

In next CLs, _log_test_results will have 2 functions:
1) log the test results in raw logging
2) print test result annotations on logdog.

So this CL is just a refactor before the upcoming changes.

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: I6285789e6a523825ecd508858c3c0124db8bb9cd
Reviewed-on: https://chromium-review.googlesource.com/1147487
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/28e3f1575822c44794b965ac05b764a38d0a2a7c/venv/skylab_suite/suite_tracking.py

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a1e1db7492cfc68d340ff535b47637c78e85aeaf

commit a1e1db7492cfc68d340ff535b47637c78e85aeaf
Author: Xixuan Wu <xixuan@chromium.org>
Date: Tue Aug 07 22:57:05 2018

autotest: Add dut_name in show test name for provision task

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: I9979c0fe04fd39433f9566bb49449ed73e99df2f
Reviewed-on: https://chromium-review.googlesource.com/1147747
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/a1e1db7492cfc68d340ff535b47637c78e85aeaf/venv/skylab_suite/suite_tracking.py

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b93ec80207fcb35b2ac740992d028a1ddd2ba6e9

commit b93ec80207fcb35b2ac740992d028a1ddd2ba6e9
Author: Xixuan Wu <xixuan@chromium.org>
Date: Tue Aug 07 22:57:27 2018

autotest: Refactor function _print_task_link_annotation.

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: If9d74a9c6153f862fcc2f8a80ea72cd73753a779
Reviewed-on: https://chromium-review.googlesource.com/1147087
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/b93ec80207fcb35b2ac740992d028a1ddd2ba6e9/venv/skylab_suite/suite_tracking.py

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/164ccc3d028d2cb807bf0e094e1171c7bcb62a9b

commit 164ccc3d028d2cb807bf0e094e1171c7bcb62a9b
Author: Xixuan Wu <xixuan@chromium.org>
Date: Tue Aug 07 22:57:42 2018

autotest: Log test links and status in logdog

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: I1d119ab0471d6f8c79d0ab00b155b9f56e813f98
Reviewed-on: https://chromium-review.googlesource.com/1147498
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/164ccc3d028d2cb807bf0e094e1171c7bcb62a9b/venv/skylab_suite/suite_tracking.py

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 8

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/08ea43015a4c0d9925b7ac831d6f30e4a3fb383a

commit 08ea43015a4c0d9925b7ac831d6f30e4a3fb383a
Author: Xixuan Wu <xixuan@chromium.org>
Date: Thu Aug 09 21:37:19 2018

autotest: Adjust task_id in swarming url to show summary.

BUG= chromium:854426 
TEST=Ran it on cros-skylab-suite-server1.hot.

Change-Id: I9fdab5e13852ed8cba965ff3bb6329db644626fb
Reviewed-on: https://chromium-review.googlesource.com/1170085
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Commit-Queue: Xixuan Wu <xixuan@chromium.org>
Tested-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/08ea43015a4c0d9925b7ac831d6f30e4a3fb383a/venv/skylab_suite/suite_tracking.py

Status: Verified (was: Assigned)

Sign in to add a comment