New issue
Advanced search Search tips

Issue 854410 link

Starred by 0 users
Status: Fixed
Owner:
dmazz...@chromium.org
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Internal chrome://accessibility page crashes due to favicons

Project Member Reported by dmazz...@chromium.org, Jun 19 2018 
On debug builds, visiting chrome://accessibility fails with this error, in this case because I had facebook.com open in one tab:

FATAL:web_request_permissions.cc(211)] Check failed: IsWebUIAllowedToMakeNetworkRequests(*request.initiator). Unsupported network request from chrome://accessibility/ for https://static.xx.fbcdn.net/rsrc.php/yo/r/iRmz9lCMBD2.ico

We shouldn't be referencing remote urls for our favicons, we can make them data urls instead.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d511014ad69416cc0c93e4a8e59b41d9a72d6485

commit d511014ad69416cc0c93e4a8e59b41d9a72d6485
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Jun 20 16:35:52 2018

Replace the favicons on the chrome://accessibility page with data urls.

WebUI doesn't allow remote network connections anymore for security reasons.

Bug:  854410 
Change-Id: I448b24e87659e1f4f0aa6955d9a0cda4bfe8c8ac
Reviewed-on: https://chromium-review.googlesource.com/1107202
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568871}
[modify] https://crrev.com/d511014ad69416cc0c93e4a8e59b41d9a72d6485/content/browser/accessibility/accessibility_ui.cc

Comment 2 by dmazz...@chromium.org, Jun 21 2018

Status: Fixed (was: Started)
►

Sign in to add a comment