New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854400 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 22
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Multidevice settings page remains attached even when other pages expand

Project Member Reported by jordynass@chromium.org, Jun 19 2018

Issue description

The settings page hides all subpages but searching its children but, because the CL https://chromium-review.googlesource.com/c/chromium/src/+/1105185 pushed the multidevice down the DOM tree, it is no longer hidden.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/443a130bb71122667b40bb24873274b15ecb4380

commit 443a130bb71122667b40bb24873274b15ecb4380
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Wed Jun 20 03:15:01 2018

[CrOS MultiDevice]: Fix bug in settings UI page

The basic settings page (via MainPageBehavior) searches its children
for settings-sections to hide when it expands a subpage. Because CL
https://chromium-review.googlesource.com/c/chromium/src/+/1105185
pushed the multidevice settings-section down the DOM tree, it is no
longer automatically hidden. To avoid dealing with the /deep/ selector
(see https://bugs.chromium.org/p/chromium/issues/detail?id=852098)
I just had the basic page take page expansion into account directly
when deciding whether to attach the
multidevice-settings-section-container.

Bug:  854400 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I89e08e5af79163146737d7ae5a9637536cb032c2
Reviewed-on: https://chromium-review.googlesource.com/1107168
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568711}
[modify] https://crrev.com/443a130bb71122667b40bb24873274b15ecb4380/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/443a130bb71122667b40bb24873274b15ecb4380/chrome/browser/resources/settings/basic_page/basic_page.js

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Status: Fixed (was: Assigned)

Sign in to add a comment