New issue
Advanced search Search tips

Issue 854391 link

Starred by 3 users
Status: Untriaged
Owner: ----
Cc:
aga...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:9179


Sign in to add a comment

Gerrit should warn If I say lgtm but forget to +1

Project Member Reported by thakis@chromium.org, Jun 6 2018 
Subject says it all. I often forget the (to me redundant) +1 button.

Comment 1 by david.pu...@gmail.com, Jun 6 2018

Summary: Gerrit should warn If I say lgtm but forget to +1 (was: Gerrit should warm If I say lgtm but forget to +1)
See related  issue 3130 .  Special handling of "LGTM" was removed in change https://gerrit-review.googlesource.com/c/gerrit/+/63762

Comment 2 by thakis@chromium.org, Jun 6 2018 

That cl talks about +2. Chromium only has +1 at most, so maybe that could be brought back for these projects?

Comment 3 by david.pu...@gmail.com, Jun 6 2018 

It's not likely to be brought back in anything like its original form because that was on the GWT UI, and we've now moved on to Polymer.

I'll leave it up to the Polygerrit team to decide how, if at all, this can be implemented for Polygerrit.

Comment 4 by wyatta@google.com, Jun 12 2018

Cc: aga...@chromium.org
At this time, this LGTM behavior is part of a Chromium-specific plugin. Adding agable@

Comment 5 by kaspern@google.com, Jun 19 2018

Project: chromium
Moved issue gerrit:9179 to now be issue chromium:854391.

Comment 6 by benhenry@google.com, Jan 10

Status: Untriaged (was: New)
Issue moved from a project with a different set of status labels. "New" is not a supported status in /p/chromium, so these ended up in a black-hole.
►

Sign in to add a comment