New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854383 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros.TradefedTest._wait_for_arc_boot() is flaky

Project Member Reported by lhchavez@chromium.org, Jun 19 2018

Issue description

_wait_for_arc_boot() is supposed to wait until the org.chromium.arc.intent_helper process is alive. But it does not pass in the ignore_status flag, so it fails if it is not alive on the very first try.

Example failure: https://luci-milo.appspot.com/buildbot/chromeos/caroline-arcnext-paladin/752
 

Comment 2 by uekawa@google.com, Jun 20 2018

I'm just curious, but does this mean we have become slower (and was passing before because we were ready in the first try) ?
¯\_(ツ)_/¯

This was always inherently racy. Maybe it passes 99.x% of the time and we just managed to catch the one time it failed and decided to fix it instead of ignoring it.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f17f8d583e01d5511a6e9506a0ce7bbad8b02957

commit f17f8d583e01d5511a6e9506a0ce7bbad8b02957
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Thu Jun 21 23:31:21 2018

tradefed_test: Make _wait_for_arc_boot actually wait

This change makes _wait_for_arc_boot not fail if the
org.chromium.arc.intent_helper process is not alive in the very first
try.

BUG= chromium:854383 
TEST=pre-cq

Change-Id: Id7ec0f106ae37b48fe089e6c709cbcaf4169fd5e
Reviewed-on: https://chromium-review.googlesource.com/1107101
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>

[modify] https://crrev.com/f17f8d583e01d5511a6e9506a0ce7bbad8b02957/server/cros/tradefed_test.py

Status: Fixed (was: Started)

Comment 7 by uekawa@google.com, Jun 22 2018

Cc: yunfanc@chromium.org
Labels: ArcConstable
The Issue is fixed 4 days go but still i am seeing the same issue on TOT R69-10818.0.0.

please update here with build / arc version when the fix is available.


https://sponge.corp.google.com/target?id=3640b429-ad2d-46b4-8cdf-889a19fb3886&target=caroline-arcnext-release%2FR69-10818.0.0%2Farc-cts%2Fcheets_CTS_P.9.0_r1.arm.CtsJniTestCases&searchFor=R69-10818.0.0+caroline-arcnext+CtsJniTestCases

The new failure is being caused by https://bugs.chromium.org/p/chromium/issues/detail?id=853584
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 11

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8aecaba204db74568104d10c0e75da18ca1a6b04

commit 8aecaba204db74568104d10c0e75da18ca1a6b04
Author: Luis Hector Chavez <lhchavez@google.com>
Date: Wed Jul 11 18:46:07 2018

tradefed_test: Make _wait_for_arc_boot actually wait

This change makes _wait_for_arc_boot not fail if the
org.chromium.arc.intent_helper process is not alive in the very first
try.

BUG= chromium:854383 
TEST=pre-cq

Change-Id: Id7ec0f106ae37b48fe089e6c709cbcaf4169fd5e
Reviewed-on: https://chromium-review.googlesource.com/1107101
Commit-Ready: Luis Hector Chavez <lhchavez@chromium.org>
Tested-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
(cherry picked from commit f17f8d583e01d5511a6e9506a0ce7bbad8b02957)
Reviewed-on: https://chromium-review.googlesource.com/1133882
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/8aecaba204db74568104d10c0e75da18ca1a6b04/server/cros/tradefed_test.py

Sign in to add a comment