New issue
Advanced search Search tips

Issue 854382 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Jul 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR

Blocking:
issue 864810



Sign in to add a comment

WebXR: Update XR Input verbiage

Project Member Reported by bajones@chromium.org, Jun 19 2018 
As indicated in https://github.com/immersive-web/webxr/pull/342

The enums and some of the attributes involved in the WebXR input system were changed recently, and Chrome's implementation should be updated to match.

Renames:
XRPointerOrigin -> XRTargetRayMode
  "head" -> "gazing"
  "hand" -> "pointing"
  "screen" -> "tapping"
XRInputSource.pointerOrigin -> XRInputSource.targetRayMode
XRInputPose.pointerMatrix -> XRInputPose.targetRayMatrix*

*targetRayMatrix may soon be replaced with targetRay, depending on the outcome of https://github.com/immersive-web/webxr/pull/357

Comment 1 by codei...@gmail.com, Jun 20 2018 

If no one is working on this, can I take this issue?

Comment 2 by bajones@chromium.org, Jun 20 2018 

Feel free, sure!
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daf012827e83a2e521fe59758e4575a82528e8e5

commit daf012827e83a2e521fe59758e4575a82528e8e5
Author: codeimpl <codeimpl@gmail.com>
Date: Thu Jul 05 11:22:03 2018

[WebXR] Update pointerOrigin and enum values

The enums and some of the attributes involved in the WebXR input system
were changed recently[1].

[1] https://github.com/immersive-web/webxr/pull/342

Bug:  854382 
Change-Id: I56fe5909d7015461cb7314d23a12b194f148d483
Reviewed-on: https://chromium-review.googlesource.com/1112881
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572756}
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/device/vr/oculus/oculus_render_loop.cc
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/device/vr/openvr/openvr_render_loop.cc
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/device/vr/public/mojom/vr_service.mojom
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/WebKit/LayoutTests/xr/getInputPose_hand.html
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/WebKit/LayoutTests/xr/xrInputSource_add_remove.html
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/blink/renderer/modules/xr/xr_canvas_input_provider.cc
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/blink/renderer/modules/xr/xr_frame.cc
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/blink/renderer/modules/xr/xr_input_source.cc
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/blink/renderer/modules/xr/xr_input_source.h
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/blink/renderer/modules/xr/xr_input_source.idl
[modify] https://crrev.com/daf012827e83a2e521fe59758e4575a82528e8e5/third_party/blink/renderer/modules/xr/xr_session.cc

Comment 4 by bajones@chromium.org, Jul 6

Status: Fixed (was: Available)

Comment 5 by ddorwin@chromium.org, Jul 17

Blocking: 864810
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a

commit 8a9a50cafcb8b8da14601a20fbd83e4b3b81895a
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Jul 20 01:06:57 2018

Update XRTargetRayMode enums again

Received feedback that the previous enums went against platform norms

Bug:  854382 
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I278fbbc204f45e5032ac081e535bae5f62bc1cd3
Reviewed-on: https://chromium-review.googlesource.com/1144249
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576741}
[modify] https://crrev.com/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a/third_party/WebKit/LayoutTests/xr/getInputPose_hand.html
[modify] https://crrev.com/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a/third_party/WebKit/LayoutTests/xr/resources/xr-device-mocking.js
[modify] https://crrev.com/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a/third_party/WebKit/LayoutTests/xr/xrInputSource_add_remove.html
[modify] https://crrev.com/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a/third_party/blink/renderer/modules/xr/xr_canvas_input_provider.cc
[modify] https://crrev.com/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a/third_party/blink/renderer/modules/xr/xr_frame.cc
[modify] https://crrev.com/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a/third_party/blink/renderer/modules/xr/xr_input_source.cc
[modify] https://crrev.com/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a/third_party/blink/renderer/modules/xr/xr_input_source.h
[modify] https://crrev.com/8a9a50cafcb8b8da14601a20fbd83e4b3b81895a/third_party/blink/renderer/modules/xr/xr_input_source.idl
►

Sign in to add a comment