[Autotest failure] network_WiFi_AttenuatedPerf failing with "float() argument must be a string or a number" |
||||
Issue description
Fix graph name type error.
06/19 12:59:53.854 WARNI| test:0637| The test failed with the following exception
Traceback (most recent call last):
File "/usr/local/autotest/client/common_lib/test.py", line 631, in _exec
_call_test_function(self.execute, *p_args, **p_dargs)
File "/usr/local/autotest/client/common_lib/test.py", line 837, in _call_test_function
raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled TypeError: float() argument must be a string or a number
Traceback (most recent call last):
File "/usr/local/autotest/client/common_lib/test.py", line 831, in _call_test_function
return func(*args, **dargs)
File "/usr/local/autotest/client/common_lib/test.py", line 495, in execute
dargs)
File "/usr/local/autotest/client/common_lib/test.py", line 362, in _call_run_once_with_retry
postprocess_profiled_run, args, dargs)
File "/usr/local/autotest/client/common_lib/test.py", line 400, in _call_run_once
self.run_once(*args, **dargs)
File "/usr/local/autotest/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py", line 114, in run_once
graph=graph_name)
File "/usr/local/autotest/client/common_lib/test.py", line 183, in output_perf_value
value = float(value)
TypeError: float() argument must be a string or a number
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bd17064216b4a299b52cc7951e326008bf23d68b commit bd17064216b4a299b52cc7951e326008bf23d68b Author: harpreet <harpreet@google.com> Date: Thu Aug 30 04:05:51 2018 autotest: network_WiFi_AttenuatorPerf - Fix multiple issues Fixing 3 issues that we have see on the attenuated (grover) setups in the lab. 1) Unhandled timeout when opening telnet connection ( crbug.com/854377 ) 2) TypeError for signal level. output_perf_value expects string or number but wifi_signal_level returns None if signal is not detected. This usually happens on runs with high attenuation ( crbug.com/854378 ) 3) Telnet commands fails to return valid data. We use to see this error sometimes prior to Aug 10 but since then failures resulting from this has spiked. The issue seems to be with telnet connection that we create though the connection remains open, we stop receiving expected data using telnet expect. This seems to get worse with large number of telnet calls. Closing and reopening telnet connection fixes the issue. ( crbug.com/876945 ) BUG= chromium:854377 , chromium:854378 , chromium:876945 TEST=Tested against eve in grover setup in wifi lab. Change-Id: Iccb711c59f29a216ea6a936c7757b4048fd0cc1c Reviewed-on: https://chromium-review.googlesource.com/1188984 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/attenuator.py [modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/telnet_helper.py [modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py [modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/attenuator_controller.py
,
Aug 30
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/45c8391e2a4b0cf2155230204d253a91ac763ab7 commit 45c8391e2a4b0cf2155230204d253a91ac763ab7 Author: harpreet <harpreet@google.com> Date: Mon Sep 10 18:40:43 2018 autotest: network_WiFi_AttenuatorPerf - Fix multiple issues Fixing 3 issues that we have see on the attenuated (grover) setups in the lab. 1) Unhandled timeout when opening telnet connection ( crbug.com/854377 ) 2) TypeError for signal level. output_perf_value expects string or number but wifi_signal_level returns None if signal is not detected. This usually happens on runs with high attenuation ( crbug.com/854378 ) 3) Telnet commands fails to return valid data. We use to see this error sometimes prior to Aug 10 but since then failures resulting from this has spiked. The issue seems to be with telnet connection that we create though the connection remains open, we stop receiving expected data using telnet expect. This seems to get worse with large number of telnet calls. Closing and reopening telnet connection fixes the issue. ( crbug.com/876945 ) BUG= chromium:854377 , chromium:854378 , chromium:876945 TEST=Tested against eve in grover setup in wifi lab. Change-Id: Iccb711c59f29a216ea6a936c7757b4048fd0cc1c Reviewed-on: https://chromium-review.googlesource.com/1188984 Commit-Ready: Harpreet Grewal <harpreet@chromium.org> Tested-by: Harpreet Grewal <harpreet@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> (cherry picked from commit bd17064216b4a299b52cc7951e326008bf23d68b) Reviewed-on: https://chromium-review.googlesource.com/1196769 Reviewed-by: Harpreet Grewal <harpreet@chromium.org> Commit-Queue: Harpreet Grewal <harpreet@chromium.org> Trybot-Ready: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/attenuator.py [modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/telnet_helper.py [modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py [modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/attenuator_controller.py
,
Sep 13
|
||||
►
Sign in to add a comment |
||||
Comment 1 by harpreet@chromium.org
, Aug 24