New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854377 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[Autotest failure] network_WiFi_AttenuatedPerf failing with "Unhandled timeout: timed out"

Project Member Reported by harpreet@chromium.org, Jun 19 2018

Issue description

Sometimes the test times out when opening telnet connection. Catch the exception and potentially increase timeout limit.

06/17 09:28:22.570 WARNI|              test:0637| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/client/common_lib/test.py", line 618, in _exec
    *args, **dargs)
  File "/usr/local/autotest/client/common_lib/test.py", line 837, in _call_test_function
    raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled timeout: timed out
Traceback (most recent call last):
  File "/usr/local/autotest/client/common_lib/test.py", line 831, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/client/common_lib/test.py", line 746, in _cherry_pick_call
    return func(*p_args, **p_dargs)
  File "/usr/local/autotest/server/cros/network/wifi_cell_test_base.py", line 83, in warmup
    self._wifi_context.setup()
  File "/usr/local/autotest/server/cros/network/wifi_test_context_manager.py", line 213, in setup
    attenuator_addr)
  File "/usr/local/autotest/server/cros/network/attenuator_controller.py", line 106, in __init__
    self._attenuator = attenuator.Attenuator(hostname, num_atten)
  File "/usr/local/autotest/server/cros/network/attenuator.py", line 18, in __init__
    self.open(host)
  File "/usr/local/autotest/server/cros/network/attenuator.py", line 33, in open
    self._tnhelper.open(host, port)
  File "/usr/local/autotest/server/cros/network/telnet_helper.py", line 34, in open
    self._tn.open(hostname, port, LONG_TIMEOUT)
  File "/usr/lib/python2.7/telnetlib.py", line 227, in open
    self.sock = socket.create_connection((host, port), timeout)
  File "/usr/lib/python2.7/socket.py", line 571, in create_connection
    raise err
timeout: timed out
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bd17064216b4a299b52cc7951e326008bf23d68b

commit bd17064216b4a299b52cc7951e326008bf23d68b
Author: harpreet <harpreet@google.com>
Date: Thu Aug 30 04:05:51 2018

autotest: network_WiFi_AttenuatorPerf - Fix multiple issues

Fixing 3 issues that we have see on the attenuated (grover) setups in
the lab.
1) Unhandled timeout when opening telnet connection ( crbug.com/854377 )
2) TypeError for signal level. output_perf_value expects string or
number but wifi_signal_level returns None if signal is not detected.
This usually happens on runs with high attenuation ( crbug.com/854378 )
3) Telnet commands fails to return valid data. We use to see this error
sometimes prior to Aug 10 but since then failures resulting from this
has spiked. The issue seems to be with telnet connection that we create
though the connection remains open, we stop receiving expected data
using telnet expect. This seems to get worse with large number of
telnet calls. Closing and reopening telnet connection fixes the issue.
( crbug.com/876945 )

BUG= chromium:854377 ,  chromium:854378 ,  chromium:876945 
TEST=Tested against eve in grover setup in wifi lab.

Change-Id: Iccb711c59f29a216ea6a936c7757b4048fd0cc1c
Reviewed-on: https://chromium-review.googlesource.com/1188984
Commit-Ready: Harpreet Grewal <harpreet@chromium.org>
Tested-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/attenuator.py
[modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/telnet_helper.py
[modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py
[modify] https://crrev.com/bd17064216b4a299b52cc7951e326008bf23d68b/server/cros/network/attenuator_controller.py

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 10

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/45c8391e2a4b0cf2155230204d253a91ac763ab7

commit 45c8391e2a4b0cf2155230204d253a91ac763ab7
Author: harpreet <harpreet@google.com>
Date: Mon Sep 10 18:40:43 2018

autotest: network_WiFi_AttenuatorPerf - Fix multiple issues

Fixing 3 issues that we have see on the attenuated (grover) setups in
the lab.
1) Unhandled timeout when opening telnet connection ( crbug.com/854377 )
2) TypeError for signal level. output_perf_value expects string or
number but wifi_signal_level returns None if signal is not detected.
This usually happens on runs with high attenuation ( crbug.com/854378 )
3) Telnet commands fails to return valid data. We use to see this error
sometimes prior to Aug 10 but since then failures resulting from this
has spiked. The issue seems to be with telnet connection that we create
though the connection remains open, we stop receiving expected data
using telnet expect. This seems to get worse with large number of
telnet calls. Closing and reopening telnet connection fixes the issue.
( crbug.com/876945 )

BUG= chromium:854377 ,  chromium:854378 ,  chromium:876945 
TEST=Tested against eve in grover setup in wifi lab.

Change-Id: Iccb711c59f29a216ea6a936c7757b4048fd0cc1c
Reviewed-on: https://chromium-review.googlesource.com/1188984
Commit-Ready: Harpreet Grewal <harpreet@chromium.org>
Tested-by: Harpreet Grewal <harpreet@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>
(cherry picked from commit bd17064216b4a299b52cc7951e326008bf23d68b)
Reviewed-on: https://chromium-review.googlesource.com/1196769
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>
Commit-Queue: Harpreet Grewal <harpreet@chromium.org>
Trybot-Ready: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/attenuator.py
[modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/telnet_helper.py
[modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/site_tests/network_WiFi_AttenuatedPerf/network_WiFi_AttenuatedPerf.py
[modify] https://crrev.com/45c8391e2a4b0cf2155230204d253a91ac763ab7/server/cros/network/attenuator_controller.py

Status: Verified (was: Fixed)

Sign in to add a comment