New issue
Advanced search Search tips

Issue 854374 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Highlight the Cast icon when showing Media Remoting or cloud services dialog

Project Member Reported by taku...@chromium.org, Jun 19 2018

Issue description

The dialogs are anchored to the icon, so it should be depressed when they are shown.
 

Comment 1 by mfo...@chromium.org, Jun 25 2018

Blocking: -754101
Labels: -Pri-1 Pri-2
Nice to have
Labels: -M-69 -Target-69 Target-70 M-70
Cc: powerb@chromium.org
Labels: -Target-70 -M-70 Target-71 M-71
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aed2fbc98cd244a46543a52e214cf7741351b07e

commit aed2fbc98cd244a46543a52e214cf7741351b07e
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Sep 13 23:10:45 2018

Depress the Cast toolbar icon when showing Media Remoting dialog

Put the Cast toolbar icon in pressed state while showing the Media
Remoting dialog.

Bug: 854374
Change-Id: Ie75f7905e7c796375ec85075a56bbdf15c73d36c
Reviewed-on: https://chromium-review.googlesource.com/1191063
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591197}
[modify] https://crrev.com/aed2fbc98cd244a46543a52e214cf7741351b07e/chrome/browser/ui/views/media_router/media_remoting_dialog_view.cc
[modify] https://crrev.com/aed2fbc98cd244a46543a52e214cf7741351b07e/chrome/browser/ui/views/media_router/media_remoting_dialog_view.h

Status: Fixed (was: Assigned)
Owner: ----
Status: Available (was: Fixed)
We still have to depress the icon when the cloud services dialog is shown. It's a bit complicated because that dialog is shown via the context menu, and when the context menu gets hidden it resets the icon state. 
Labels: -M-71 -Target-71 Target-72 M-72
Moving to M-72 as this is not in anyone's queue at the moment.
Labels: -Pri-2 -M-72 -Target-72 Pri-3

Sign in to add a comment