New issue
Advanced search Search tips

Issue 854371 link

Starred by 2 users
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jun 2018
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 822061



Sign in to add a comment

Tab hovered state still not painted correctly

Project Member Reported by pkasting@chromium.org, Jun 19 2018 
Place the mouse cursor on the right edge of a tab.  Draw downwards into the curve at the bottom (where I've placed a red dot in the attached image).  The curves get clipped by the surrounding tabs.

This is pretty easy to repro by scrubbing across the bottom of the tabstrip from right to left as well.
hovered.png
1.7 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf6e73fb56fa1ab8b058eeab82ba68fae1d5d8e

commit ecf6e73fb56fa1ab8b058eeab82ba68fae1d5d8e
Author: Allen Bauer <kylixrd@chromium.org>
Date: Wed Jun 20 18:46:01 2018

Don't blindly overwrite the |hovered_tab| without painting the current one first.

There are issues here that manifested differently. They where all caused by
the same core issue. Since the tabs overlap visually, two tabs can report as
being hovered so make sure the |hovered_tab| variable isn't blindly overwritten
without first making sure it's painted.

Bug:  853240 
Bug:  854371 
Change-Id: I62643659c6416cb23637613d0c3da83c6f4605f2
Reviewed-on: https://chromium-review.googlesource.com/1108338
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568950}
[modify] https://crrev.com/ecf6e73fb56fa1ab8b058eeab82ba68fae1d5d8e/chrome/browser/ui/views/tabs/tab_strip.cc

Comment 2 by kylixrd@chromium.org, Jun 20 2018

Status: Fixed (was: Assigned)

Comment 3 by pkasting@chromium.org, Jun 21 2018

Cc: pkasting@chromium.org
 Issue 855214  has been merged into this issue.
►

Sign in to add a comment