New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854365 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Sep 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 855092

Blocking:
issue 854367



Sign in to add a comment

Land basic ContentView API for the Content Service

Project Member Reported by roc...@chromium.org, Jun 19 2018

Issue description

Should be sufficient to embed a navigable content view from an external process like Ash.

See https://docs.google.com/document/d/1AQfbZhYWBgXIvqdnAAwLioBN7Agep7errqo7YMrpASI/edit#heading=h.ya5hq9v22y3p for
a high-level overview and (eventually) links to more detailed
documentation.
 

Comment 1 by roc...@chromium.org, Jun 19 2018

Blocking: 854367

Comment 2 by roc...@chromium.org, Jun 19 2018

Labels: -Pri-3 Pri-2

Comment 3 by roc...@chromium.org, Jun 20 2018

Components: Internals>Services>Content

Comment 4 by roc...@chromium.org, Jun 21 2018

Blockedon: 855092

Comment 5 by jam@chromium.org, Jun 22 2018

Description: Show this description
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce

commit 84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Jun 22 21:54:14 2018

Initial commit of a basic Content Service

The Content Service is a new s13n project intended to servicify
the bulk of the content layer's functionality, namely the ability for
applications to embed navigable web content views backed by isolated,
sandboxed content handlers. See https://tinyurl.com/ycrx5tgq for
a high-level overview and (eventually) links to more detailed
documentation.

This CL lands a trivial client View API with some tiny mojom surface
between it and the Content Service. The API as-is may be completely
throw-away, but this change gets all the necessary boilerplate and
plumbing landed.

The ContentServiceDelegate and ContentViewDelegate C++ interfaces are
exposed by the Content Service impl so that it can delegate to private
src/content implementation details without a dependency on src/content.

The browser itself is granted access to connect to Content Service for
now so that basic integration testing can be done via
content_browsertests. One such test is added here to verify a
functioning end-to-end connection between a client's View instance
and an actual backing WebContentsImpl.

Bug:  854365 
Change-Id: Idd8e4d0e5f2922ffc48686a4057e6e7c262c3cc3
Reviewed-on: https://chromium-review.googlesource.com/1107012
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569797}
[modify] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/browser/BUILD.gn
[modify] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/browser/DEPS
[modify] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/browser/browser_context.cc
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/browser/content_service_browsertest.cc
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/browser/content_service_delegate_impl.cc
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/browser/content_service_delegate_impl.h
[modify] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/public/app/BUILD.gn
[modify] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/content/test/BUILD.gn
[modify] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/BUILD.gn
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/BUILD.gn
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/OWNERS
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/manifest.json
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/public/cpp/BUILD.gn
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/public/cpp/view.cc
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/public/cpp/view.h
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/public/mojom/BUILD.gn
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/public/mojom/OWNERS
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/public/mojom/constants.mojom
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/public/mojom/view.mojom
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/public/mojom/view_factory.mojom
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/service.cc
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/service.h
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/service_delegate.h
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/service_unittest.cc
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/view_delegate.h
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/view_factory_impl.cc
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/view_factory_impl.h
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/view_impl.cc
[add] https://crrev.com/84f58fd64c2aa9cbe2d4f6b356fb8a5a695092ce/services/content/view_impl.h

Status: Fixed (was: Assigned)
This is done

Sign in to add a comment