Right now, we are sending mouse events when we receive WM_POINTER message from pen input devices. We should make pen inputs behave like touch inputs on MacOS like what we did on Windows to support scroll, so we should send touch events instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83f54456850a92b700befbe570e599576b350409 commit 83f54456850a92b700befbe570e599576b350409 Author: lanwei <lanwei@chromium.org> Date: Thu Jun 21 23:51:04 2018 Enable the flag of direct manipulation on Mac and Linux After we enable the direct manipulation on Windows, we want to enable it on Mac and Linux as well. Bug: 854354 Change-Id: I9115f8933588c68b75e15411f0ea3e502d229e24 Reviewed-on: https://chromium-review.googlesource.com/1106971 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569457} [modify] https://crrev.com/83f54456850a92b700befbe570e599576b350409/chrome/browser/about_flags.cc [modify] https://crrev.com/83f54456850a92b700befbe570e599576b350409/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/83f54456850a92b700befbe570e599576b350409/chrome/browser/flag_descriptions.h [modify] https://crrev.com/83f54456850a92b700befbe570e599576b350409/ui/base/ui_base_features.cc [modify] https://crrev.com/83f54456850a92b700befbe570e599576b350409/ui/base/ui_base_features.h
The NextAction date has arrived: 2018-06-29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b01dce6fbbb5462ed060d93ed91f44bc8516a962 commit b01dce6fbbb5462ed060d93ed91f44bc8516a962 Author: Lan Wei <lanwei@chromium.org> Date: Mon Jul 09 19:57:38 2018 Set the pointer type correctly on Mac Because Mac sometimes does not send the tablet events when a stylus is approaching the tablet, it just sends mouse events. We have to always check the mouse events' subtype to decide if it is a stylus input or a mouse input. Bug: 854354 Change-Id: Ibda91bf7c0970778b486ee4e0d7cb14650e18952 Reviewed-on: https://chromium-review.googlesource.com/1124984 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#573416} [modify] https://crrev.com/b01dce6fbbb5462ed060d93ed91f44bc8516a962/content/browser/renderer_host/render_widget_host_view_cocoa.mm [modify] https://crrev.com/b01dce6fbbb5462ed060d93ed91f44bc8516a962/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de31a6341849baa4ea04b8e41a2227066fee5f04 commit de31a6341849baa4ea04b8e41a2227066fee5f04 Author: Lan Wei <lanwei@chromium.org> Date: Tue Jul 31 18:11:28 2018 Make pen inputs behave like touch inputs on MacOS Currently on MacOS the pen behaves like a mouse input, because we generate mouse events for the pen input. We agreed that the pen input should behave like a touch input, so we now send touch events instead. Bug: 854354 Change-Id: Iac7910e250020a8125a57fb6055fb282db3faf0e Reviewed-on: https://chromium-review.googlesource.com/1136721 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579482} [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/input/web_input_event_builders_mac.h [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/input/web_input_event_builders_mac.mm [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/render_widget_host_ns_view_client.h [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/render_widget_host_view_cocoa.h [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/render_widget_host_view_cocoa.mm [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/de31a6341849baa4ea04b8e41a2227066fee5f04/content/common/render_widget_host_ns_view.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423 commit 65c2b51b594dbff93df5a8bfc15b1a9ec8bde423 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Tue Jul 31 21:53:20 2018 Revert "Make pen inputs behave like touch inputs on MacOS" This reverts commit de31a6341849baa4ea04b8e41a2227066fee5f04. Reason for revert: This has made the Mac10.12 Tests content_unittests fail on the following tests: WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess180 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationGreater360 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess90 WebInputEventBuilderMacTest.TouchEventsWithPointerTypePenRotationLess360 WebInputEventBuilderMacTest.BuildWebTouchEvents See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14711 Original change's description: > Make pen inputs behave like touch inputs on MacOS > > Currently on MacOS the pen behaves like a mouse input, because we > generate mouse events for the pen input. We agreed that the pen input > should behave like a touch input, so we now send touch events instead. > > Bug: 854354 > Change-Id: Iac7910e250020a8125a57fb6055fb282db3faf0e > Reviewed-on: https://chromium-review.googlesource.com/1136721 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579482} TBR=meacer@chromium.org,tdresser@chromium.org,lanwei@chromium.org,nzolghadr@chromium.org Change-Id: I51b85daec63d39ef9aebb9dd727def7dfd7ca432 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854354 Reviewed-on: https://chromium-review.googlesource.com/1157304 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579584} [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/input/web_input_event_builders_mac.h [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/input/web_input_event_builders_mac.mm [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/render_widget_host_ns_view_client.h [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/render_widget_host_view_cocoa.h [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/render_widget_host_view_cocoa.mm [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/65c2b51b594dbff93df5a8bfc15b1a9ec8bde423/content/common/render_widget_host_ns_view.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/404244fe784a441a3b192029f61a5fe5d812635d commit 404244fe784a441a3b192029f61a5fe5d812635d Author: Lan Wei <lanwei@chromium.org> Date: Wed Aug 01 14:10:22 2018 Reland "Make pen inputs behave like touch inputs on MacOS" The below CL causes Mac10.12 bot fail on some content_unittests, some values were not set correctly, I made some changes to the unittest. https://chromium-review.googlesource.com/c/chromium/src/+/1136721 luci.chromium.try:mac_chromium_10.12_rel_ng TBR=tdresser@chromium.org,nzolghadr@chromium.org,meacer@chromium.org, lanwei@chromium.org Bug: 854354 Change-Id: I4a9b540b2951be4a1147e9f99088256b833fde2d Reviewed-on: https://chromium-review.googlesource.com/1157426 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#579794} [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/input/web_input_event_builders_mac.h [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/input/web_input_event_builders_mac.mm [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/render_widget_host_ns_view_client.h [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/render_widget_host_view_cocoa.h [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/render_widget_host_view_cocoa.mm [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm [modify] https://crrev.com/404244fe784a441a3b192029f61a5fe5d812635d/content/common/render_widget_host_ns_view.mojom
Comment 1 by lanwei@chromium.org
, Jun 19 2018