New issue
Advanced search Search tips

Issue 854353 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD Refresh: Address edit dialog has extra button spacing.

Project Member Reported by dpa...@chromium.org, Jun 19 2018

Issue description

See screenshots.
 
space_before.png
15.9 KB View Download
space_after.png
18.1 KB View Download

Comment 1 by dpa...@chromium.org, Jun 19 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fd2195706c96d1e55148d7b0b0427ae2fdb97d4

commit 9fd2195706c96d1e55148d7b0b0427ae2fdb97d4
Author: dpapad <dpapad@chromium.org>
Date: Tue Jun 19 23:26:28 2018

Settins MD Refresh: Fix buttons spacing in address dialog.

Bug:  854353 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2e8a75a0e87dab4b9fb806420b9961d509651b09
Reviewed-on: https://chromium-review.googlesource.com/1106969
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568637}
[modify] https://crrev.com/9fd2195706c96d1e55148d7b0b0427ae2fdb97d4/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

Comment 3 by dpa...@chromium.org, Jun 19 2018

Status: Fixed (was: Started)
Labels: TE-Verified-69.0.3466.0 TE-Verified-M69
Able to reproduce this issue on Windows 10, Mac OS 10.13.5 and Ubuntu 17.10 on the build without fix 69.0.3464.0 and the issue is fixed on the latest Canary 69.0.3466.0.
There is no extra spacing between the buttons after #top-chrome-md flag is set to refresh.
Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
854353-M69.PNG
115 KB View Download

Sign in to add a comment