New issue
Advanced search Search tips

Issue 854336 link

Starred by 1 user
Status: Fixed
Owner:
sky@chromium.org
Closed: Jun 2018
Cc:
msw@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failed: window_trees_.empty() on shutdown if keyboard shortcut viewer is open

Project Member Reported by jamescook@chromium.org, Jun 19 2018 
ToT chrome on linux desktop

Run with --enable-features=KeyboardShortcutViewerApp
Hit Ctrl-Alt-/ to open it
Hit Ctrl-Shift-Q twice to quit

[9048:9048:0619/135956.085412:FATAL:window_service.cc(38)] Check failed: window_trees_.empty(). 
#0 0x7fce7265d27c base::debug::StackTrace::StackTrace()
#1 0x7fce725ad30b logging::LogMessage::~LogMessage()
#2 0x7fce6301a449 ui::ws2::WindowService::~WindowService()
#3 0x7fce6301a52e ui::ws2::WindowService::~WindowService()
#4 0x7fce6e1a9491 service_manager::ServiceContext::~ServiceContext()
#5 0x7fce6e1a94be service_manager::ServiceContext::~ServiceContext()
#6 0x7fce6c0192d0 ash::WindowServiceOwner::~WindowServiceOwner()
#7 0x7fce6bef03de ash::Shell::~Shell()
#8 0x7fce6bef18de ash::Shell::~Shell()
#9 0x563f385b8a09 AshShellInit::~AshShellInit()
#10 0x563f385ba12a ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun()
#11 0x563f3730d9ca ChromeBrowserMainParts::PostMainMessageLoopRun()
#12 0x563f36ebb7ca chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun()
#13 0x7fce700c12c4 content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
#14 0x7fce700c3da4 content::BrowserMainRunnerImpl::Shutdown()
#15 0x7fce700bd140 content::BrowserMain()
#16 0x7fce70b559d3 content::RunBrowserProcessMain()
#17 0x7fce70b56998 content::ContentMainRunnerImpl::Run()
#18 0x7fce729108cc service_manager::Main()
#19 0x7fce70b549f4 content::ContentMain()
#20 0x563f36722b03 ChromeMain
#21 0x7fce63fc82b1 __libc_start_main
#22 0x563f3672297a _start

It might be harmless, but I thought I should mention it.

Comment 1 by sky@chromium.org, Jun 19 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9975bfffa230d77cf81a3062ea3f3c0a6dc0d05

commit f9975bfffa230d77cf81a3062ea3f3c0a6dc0d05
Author: Scott Violet <sky@chromium.org>
Date: Wed Jun 20 16:04:52 2018

chromeos: delete WindowTreeFactory before asserting no WindowTrees

WindowTreeFactory owns any WindowTrees that were created by way of
ui::mojom::WindowTreeFactory. So, WindowTreeFactory needs to be deleted before
the DCHECK that there are no more WindowTrees.

BUG= 854336 
TEST=covered by test

Change-Id: Idba2928244721579e694b434415b95cbbdf4b360
Reviewed-on: https://chromium-review.googlesource.com/1107136
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568859}
[modify] https://crrev.com/f9975bfffa230d77cf81a3062ea3f3c0a6dc0d05/services/ui/ws2/BUILD.gn
[modify] https://crrev.com/f9975bfffa230d77cf81a3062ea3f3c0a6dc0d05/services/ui/ws2/window_service.cc
[add] https://crrev.com/f9975bfffa230d77cf81a3062ea3f3c0a6dc0d05/services/ui/ws2/window_service_unittest.cc

Comment 3 by sky@chromium.org, Jun 20 2018

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b84bceb153a585cdd142d0562cc5bae8efa7472

commit 3b84bceb153a585cdd142d0562cc5bae8efa7472
Author: Scott Violet <sky@chromium.org>
Date: Wed Jun 20 21:16:55 2018

chromeos: provides wiring to start ash out of process for OopAsh

This makes the utility process create AshService for --OopAsh. AshService
will get the logic to create Shell for OopAsh.

BUG= 854336 
TEST=none

Change-Id: I266cd93b848fa6e3a8d95de2a0c3410aa6ac8d38
Reviewed-on: https://chromium-review.googlesource.com/1108507
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569021}
[modify] https://crrev.com/3b84bceb153a585cdd142d0562cc5bae8efa7472/chrome/browser/ash_service_registry.cc
[modify] https://crrev.com/3b84bceb153a585cdd142d0562cc5bae8efa7472/chrome/utility/DEPS
[modify] https://crrev.com/3b84bceb153a585cdd142d0562cc5bae8efa7472/chrome/utility/mash_service_factory.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d9e2a50f006aec0249d42faa74330a50fd886a

commit 41d9e2a50f006aec0249d42faa74330a50fd886a
Author: Scott Violet <sky@chromium.org>
Date: Wed Jun 20 23:36:00 2018

chromeos: removes usage of ash::Config from chrome/

And instead uses features::IsAshInBrowserProcess(). This is necessary to
support --enable-features=OopAsh and --enable-features=Mash. This also will
allow us to get rid of ash::Config entirely.

BUG= 854336 
TEST=covered by test

Change-Id: Iddc53634b925e7c30fc33ec52ffa362730ecf59c
Reviewed-on: https://chromium-review.googlesource.com/1108349
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569086}
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/ash/login/ui/lock_window.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/ash/login/ui/lock_window.h
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/accessibility/accessibility_extension_api_browsertest.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chrome_content_browser_client_browsertest_chromeos.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[delete] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/browser/chromeos/ash_config.cc
[delete] https://crrev.com/6488f02a8cf67761d6c890448994be988ea4d795/chrome/browser/chromeos/ash_config.h
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/display/output_protection_delegate.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/input_method/input_method_engine.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/input_method/mode_indicator_controller.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/app_launch_controller.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/ui/input_events_blocker.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/ui/login_display_host_common.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/power/ml/user_activity_controller.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/chromeos/system_logs/touch_log_source.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/exo_parts.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/app_list/chrome_app_list_model_updater.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/ash_shell_init.h
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/ash_util.h
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/launcher/browser_status_monitor.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/test/test_browser_dialog.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/chrome_views_delegate_chromeos.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/frame/browser_frame_ash.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/frame/browser_frame_ash_browsertest.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/frame/browser_frame_mash.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_chromeos.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/frame/native_browser_frame_factory_chromeos.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/screen_capture_notification_ui_views.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/views/tabs/window_finder_chromeos.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/41d9e2a50f006aec0249d42faa74330a50fd886a/chrome/browser/ui/window_sizer/window_sizer_ash.cc
►

Sign in to add a comment