New issue
Advanced search Search tips

Issue 854326 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

"org.chromium.chrome.browser.autofill.keyboard_accessory.PasswordAccessoryIntegrationTest#testPasswordSheetDisplaysProvidedItems" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 19 2018

Issue description

"org.chromium.chrome.browser.autofill.keyboard_accessory.PasswordAccessoryIntegrationTest#testPasswordSheetDisplaysProvidedItems" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyigELEgVGbGFrZSJ_b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmF1dG9maWxsLmtleWJvYXJkX2FjY2Vzc29yeS5QYXNzd29yZEFjY2Vzc29yeUludGVncmF0aW9uVGVzdCN0ZXN0UGFzc3dvcmRTaGVldERpc3BsYXlzUHJvdmlkZWRJdGVtcww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by holte@chromium.org, Jun 19 2018

Owner: fhorschig@chromium.org
Status: Assigned (was: Untriaged)
See also crbug/854224
Blocking: 853794
Labels: -Sheriff-Chromium
Assigned -> removing from sheriff's queue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a89c21724761d80a3dc7dfae2b7fdde92472245d

commit a89c21724761d80a3dc7dfae2b7fdde92472245d
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Jun 21 10:02:32 2018

[Android] Retry PasswordAccessoryIntegrationTests

Add the @RetryOnFailure annotations. These tests rely on the keyboard
which seems to have massive troubles on some trybots only.

I am still looking for a better way to ensure the keyboard is up and
will try to replace this. If this doesn't improve the tests, the next,
sad step is to disable them temporarily.

Bug:  854326 
Change-Id: I7d1bba9a5efa6213fc53c1d84e0fcf88ec3ba9dd
Reviewed-on: https://chromium-review.googlesource.com/1109679
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569203}
[modify] https://crrev.com/a89c21724761d80a3dc7dfae2b7fdde92472245d/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java

Labels: sheriff-android
These tests are still flakily failing quite often on a number of bots. 

I think the next step, per the CL commit comments, is to temporarily disable the tests. 
 Adding to the sheriff queue to disable.

Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=PasswordAccessoryIntegrationTest
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Jun 25 2018

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "org.chromium.chrome.browser.autofill.keyboard_accessory.PasswordAccessoryIntegrationTest#testPasswordSheetDisplaysProvidedItems". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyigELEgVGbGFrZSJ_b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmF1dG9maWxsLmtleWJvYXJkX2FjY2Vzc29yeS5QYXNzd29yZEFjY2Vzc29yeUludGVncmF0aW9uVGVzdCN0ZXN0UGFzc3dvcmRTaGVldERpc3BsYXlzUHJvdmlkZWRJdGVtcww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d85d0e4e8858d3c95f06940a8c6a62e132d39dcf

commit d85d0e4e8858d3c95f06940a8c6a62e132d39dcf
Author: Theresa <twellington@chromium.org>
Date: Mon Jun 25 23:54:54 2018

Disable two flaky PasswordAccessoryIntegrationTests

BUG= 854326 
TBR=fhorschig@chromium.org

Change-Id: I82893bcd20b8e33c8a0ac283574f739a23d388a6
Reviewed-on: https://chromium-review.googlesource.com/1114251
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570244}
[modify] https://crrev.com/d85d0e4e8858d3c95f06940a8c6a62e132d39dcf/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java

Components: UI>Browser>Passwords
Labels: -Sheriff-Chromium -sheriff-android M-69 OS-Android
Status: Fixed (was: Assigned)
Fixed with issue 857460. Forgot to link it in https://crrev.com/c/1219107. Please reopen if flakes again.

Sign in to add a comment