New issue
Advanced search Search tips

Issue 854270 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Clean up FLAG_ASYNC support in //base

Project Member Reported by dcheng@chromium.org, Jun 19 2018

Issue description

This is currently layered a bit oddly: while the flag itself is defined in //base, //base itself has minimal support for async files: the only async file reader that I know of is in //net.

We should try to restructure the net code to not require //base changes: in particular, maybe FileStreamContext should open the file itself with the appropriate flags and then pass the PlatformFile to File.
 

Comment 1 by mmenke@chromium.org, Jun 19 2018

FileStreamContext will be used in the sandboxed network service, so it won't be able to open files itself.

Comment 2 by mmenke@chromium.org, Jun 19 2018

Labels: -Type-Bug Type-Feature
I think we need more concrete action items here - otherwise, this bug is likely to site for 5 years before being closed as not actionable.

Comment 3 by dcheng@chromium.org, Jun 19 2018

Originally I was thinking that FLAG_ASYNC could be wholly removed from //base, since this is really only used as support for net::FileStreamContext. But it looks like we received an additional dependency from //device. Let me follow up with the owner of the //device code and figure out some concrete steps.

Comment 4 by dcheng@chromium.org, Jun 19 2018

Summary: Clean up FLAG_ASYNC support in //base (was: Clean up FILE_ASYNC support in //base)

Comment 5 by mmenke@chromium.org, Jun 27 2018

Labels: Needs-Feedback
dcheng: Ping :)
Owner: dcheng@chromium.org
Status: Assigned (was: Available)
[dcheng]:  Marking this as assigned.  Feel free to unassign once we have a path forward.
Labels: -Needs-Feedback

Sign in to add a comment