New issue
Advanced search Search tips

Issue 854267 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 853302
issue 854821
issue 855301

Blocking:
issue 859654



Sign in to add a comment

Enable MacViews by Default in Chromium Builds

Project Member Reported by robliao@chromium.org, Jun 19 2018

Issue description

Tracks the mechanical work required to enable MacViews by default.
 
Blockedon: 853302
Blockedon: 854821
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3045a6e26dbfb23a21c79cf122b2b1cb786332fd

commit 3045a6e26dbfb23a21c79cf122b2b1cb786332fd
Author: Robert Liao <robliao@chromium.org>
Date: Thu Jun 21 22:57:58 2018

Set a ConstrainedDialogWebView Minimum Size of 1x1 on Mac

MacOS does not handle zero-sized windows well.

BUG= 854267 

Change-Id: I3da67cef7abdc035ca6378d5cb31dc68a097ee67
Reviewed-on: https://chromium-review.googlesource.com/1109200
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569402}
[modify] https://crrev.com/3045a6e26dbfb23a21c79cf122b2b1cb786332fd/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

Blockedon: 855301
Labels: MacViews-Release
Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Summary: Enable MacViews by Default in Chromium Builds (was: Enable MacViews by Default in Chrome)
Status: Fixed (was: Assigned)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1822fbdb820d3c518eea72910de72ceba4652483

commit 1822fbdb820d3c518eea72910de72ceba4652483
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu Jun 28 16:22:20 2018

Reland "variations: add client config for ViewsBrowserWindows"

This is a reland of f824b3a3926819d6398b7a7b3da1e251d33417da

Original change's description:
> variations: add client config for ViewsBrowserWindows
>
> Bug: 827247
> Change-Id: Ic09c38f7b658b1f6d79ecec8a6d0895aca44d797
> Reviewed-on: https://chromium-review.googlesource.com/1017460
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565782}

Relanding the CL.

Bug: 827247,851463
TBR: isherman@chromium.org
Change-Id: Ic3b23594fa74b24023924ad4107bf262e641bfb7
Reviewed-on: https://chromium-review.googlesource.com/1106498
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571154}
[modify] https://crrev.com/1822fbdb820d3c518eea72910de72ceba4652483/testing/variations/fieldtrial_testing_config.json
Components: Internals>Views
Status: Started (was: Fixed)
Note: the change linked above did *not* fix this - this still needs to be changed: https://cs.chromium.org/chromium/src/ui/base/ui_base_features.cc?q=ViewsBrowserWindows&sq=package:chromium&g=0&l=156
Labels: -MacViews-Release
Blocking: 859654
Status: Fixed (was: Started)
The above change (1822fbdb820d3c518eea72910de72ceba4652483) enables MacViews by default for Chromium builds including waterfall and CQ.

It does not enable it by default for Chrome builds.

I've filed http://crbug.com/859654 to enable MacViews by default for all builds.
Labels: Group-Feature_Process

Sign in to add a comment