New issue
Advanced search Search tips

Issue 854258 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[History DB] No further tasks on the database should be performed after an error

Project Member Reported by jkrcal@chromium.org, Jun 19 2018

Issue description

When an error gets reported to HistoryBackend::DatabaseErrorCallback(), we post a task to HistoryBackend::KillHistoryDatabase that closes the db and sets db_ to nullptr which protects against further DB operations.

This allows other tasks to access the DB in the meantime (before KillHistoryDatabase gets run). This is dangerous.

We should
 - either block further tasks from accessing the DB or
 - kill the database immediately.
 

Sign in to add a comment