Credit card save infobar icon not aligned with the title |
||||||||
Issue descriptionAfter crrev.com/c/1099178 that replaces the long titles in the local save scenario with the same short title as the upstream case the infobar icon seems misaligned with the title.
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3 commit 7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Jun 22 02:23:06 2018 [AF][IOS] Aligns the credit card save infobar icon with the title label - Replaces the credit card save infobar icon with a new one with smaller intrinsic padding so it can be better aligned with the title text. - Also adjusts the line height of the labels in the infobar. - New PNGs are pngcrushed. TBR=mathp Bug: 854246 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0425e43e3d44b058df3badd7dd1fa8d16d5787e6 Reviewed-on: https://chromium-review.googlesource.com/1111013 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569508} [modify] https://crrev.com/7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3/components/resources/default_100_percent/autofill/infobar_autofill_cc.png [modify] https://crrev.com/7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3/components/resources/default_200_percent/autofill/infobar_autofill_cc.png [modify] https://crrev.com/7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3/components/resources/default_300_percent/autofill/infobar_autofill_cc.png [modify] https://crrev.com/7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
,
Jun 22 2018
,
Jun 22 2018
,
Jun 22 2018
This bug requires manual review: Less than 28 days to go before AppStore submit on M68 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 22 2018
Let's get canary verification.
,
Jun 25 2018
,
Jun 26 2018
https://drive.google.com/file/d/1rcNcoZwErW0IEunyxIn8ECr-KH6RGCa4/view?usp=sharing Verified as per the steps in #0 and #2 on iPad iOS 11.4, iPhone X iOS 11.4 on build 69.0.3473.0 Canary
,
Jun 28 2018
Approved.
,
Jul 2
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a649bbe61323574195a1f405fd149a439a1305a commit 1a649bbe61323574195a1f405fd149a439a1305a Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Jul 03 15:11:11 2018 [AF][IOS] Aligns the credit card save infobar icon with the title label - Replaces the credit card save infobar icon with a new one with smaller intrinsic padding so it can be better aligned with the title text. - Also adjusts the line height of the labels in the infobar. - New PNGs are pngcrushed. TBR=mathp Bug: 854246 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0425e43e3d44b058df3badd7dd1fa8d16d5787e6 Reviewed-on: https://chromium-review.googlesource.com/1111013 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#569508}(cherry picked from commit 7ccd5d7cb077235d6e9a7eefcc92b3841267a0e3) Reviewed-on: https://chromium-review.googlesource.com/1124819 Reviewed-by: Moe Ahmadi (slow July 3) <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#588} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/1a649bbe61323574195a1f405fd149a439a1305a/components/resources/default_100_percent/autofill/infobar_autofill_cc.png [modify] https://crrev.com/1a649bbe61323574195a1f405fd149a439a1305a/components/resources/default_200_percent/autofill/infobar_autofill_cc.png [modify] https://crrev.com/1a649bbe61323574195a1f405fd149a439a1305a/components/resources/default_300_percent/autofill/infobar_autofill_cc.png [modify] https://crrev.com/1a649bbe61323574195a1f405fd149a439a1305a/ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
,
Jul 11
Verified the issue on 68.0.3440.57 beta tested on iPhone 7+(iOS 11). Verified as per the steps in Comment #2 works fine |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mahmadi@chromium.org
, Jun 19 2018