New issue
Advanced search Search tips

Issue 854230 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Contextual Search is hidden behind bottom toolbar

Project Member Reported by mdjones@chromium.org, Jun 19 2018

Issue description

Contextual search is hidden behind the bottom toolbar when triggered. It looks like the android view is not being hidden. This should be a simple fix by adding a ContextualSearchObserver (similar to what we do for the bottom sheet: https://codesearch.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetController.java?rcl=3e3eb3f17d17de467705d58f504da6ca63d2e9c5&l=204).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3504586e6d1da7f6eb01c303dfeb207061de00f8

commit 3504586e6d1da7f6eb01c303dfeb207061de00f8
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Jun 21 18:30:33 2018

Handle interaction between Contextual Search and bottom toolbar

The contextual search manager is passed into the bottom toolbar's
init function allowing us to attach an observer to it. This allows
us to show and hide the bottom toolbar's android view which was
previously obscuring contextual search.

Bug:  854230 
Change-Id: Ieefbc233bacfb90d31f0110ed3f96957b10f069a
Reviewed-on: https://chromium-review.googlesource.com/1106552
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569329}
[modify] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
[modify] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
[modify] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Status: Fixed (was: Assigned)

Sign in to add a comment